Comma in values fix #256
Merged
Comma in values fix #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynsmi
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
I know jachin tried json encoding from the elm side 🤔 and had to revert it a bunch https://github.com/DripEmail/drip-elm/pull/2541
I dont have a lot of the context as to what went wrong. But if we've tested that this works with a bunch of different single selects it looks good to me!
| @@ -3,6 +3,8 @@ | |||
| "title": "Build much-select for development", | |||
| "command": [ | |||
| "watchexec", | |||
| "--project-origin", | |||
There was a problem hiding this comment.
tested locally and i can still run successfully with this so im good with these changes 👍🏻
sbone
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: GG-327
Partial fix for commas in much select options. The issue comes up because we are using comma separated encoding for the selected value in most places. We get the selected value by splitting on
,.This updates comma separated encoding to skip spitting on
,for single selects. A single select should only have one selected value, so there is no need to split in that case.A more general fix would probably require switching to JSON encoding everywhere.