make -Werror controllable

[vapier]

Move the -Werror flag into a variable so we can disable it if need be.

[r0m30]

Hi,
This makefiles are created and controlled by the IDE (netbeans) that I use to develop in Linux. Changing them isn't really an option as the IDE believes that it owns them and will recreate them whenever it wants to.

Why would you not want -Werror ? That is a requirement for some distro packaging so we can't accept any code without it.

[vapier]

it isn't feasible or realistic to handle every single generated warning. there's no way you're going to validate every possible combination of compiler/c library/optimization/architecture out there. warnings in gcc (both good & false positives) change with every version and can differ strongly based on optimization flags or the target architecture behavior. many warnings too are triggered by the C library headers.

i don't have a problem with the git repo defaulting to -Werror. but it doesn't make sense to force all builds to always use it. my change also has zero impact on the default behavior, or on distros that want to enforce -Werror themselves.

[r0m30]

Did you see the first paragraph? The files you are modifying are generated. Patching them is a futile exercise, they will be replaced by the IDE whenever you make a change to the project.

[vapier]

then where do you want things fixed ? you're clearly the one in control, so you need to tell me how to fix this.

[r0m30]

How about this...
You use your patched files until the next release and when I create a new relesase I'll add two new configurations, one for 32bit with no -Werror and one for 64bit with no -Werror to sedutil and LinuxPBA.

[vapier]

hacking things locally (for Gentoo & Chromium OS) isn't an issue ... that's done. we can wait for the next release to drop the hacks and move to a better target.

if you're going to be tweaking things, it'd also be nice to drop the hardcoding of -O2 and -g in many places. distros doing their own builds will frequently want to use their own optimization settings.

[cristim]

I forked the project into a new Github organization, and it's available at https://github.com/sedutil/sedutil

Please join us there and re-submit this PR, we promise to merge it timely after passing the code review.

[r0m30]

There is now a standard autotools build in the root directory, it builds both sedutil-cli and linuxpba by default but each has it's own target as well. You should be able to use the standard methods to override the defaults using this. It will be maintained because it's needed for the pba build. I'm no autotools wizard so if it needs to be changed to give you the flexibility you need patch away.

[vapier]

the build still hardcodes the -Werror flag which we don't want. should I file a bug for you to address it?

[vapier]

refiled as #453 then