You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is an error generated from this bug?
Yes Invalid pot size (3) (0.50 vs pot:0.50 rake:0.50 jpt:0.00) for hand #162227643729
If the Poker Now csv log is saved before a hand is complete the the last hand in the log will be incomplete and will likely result in causing an error when the ohh file is imported into HM3. It therefore necisarry to check if the final hand is incomplete and if it is, remove the hand from the hands dictionary in order to prevent the script from trying to parse text from an incomplete hand.
A general idea of how to test if the hand information is complete, maybe the line indicating the end of the hand can be useful. The line indicating the end of the hand comes in the form "-- end of hand #<integer>". The integer is the hand number from the line indicating the beginning of the hand. When the last line of the file is parsed we can do a test to check, if the number from the beginning of the hand does not equal the number from the end of the hand then the hand information is incomplete because the last end hand # will be from the previous hand, indicating the file was saved before the final hand was complete.
Expected Behavior
All hand converted in ohh should have complete hand information, and any hands with incomplete information should be removed from the hands dictionary before the ohh file is created.
Screenshots
Desktop
OS: Windows 10
Version: 10.0.19043
Language: Python, OHH, Poker Now
Version: 3.2.10, 1.2.2, 3.1.25
File: main.py
Version: 1.1.2
Additional Context
Fixing this bug may solve some of the problems in issue #29
The text was updated successfully, but these errors were encountered:
Description
Is an error generated from this bug?
Yes
Invalid pot size (3) (0.50 vs pot:0.50 rake:0.50 jpt:0.00) for hand #162227643729
If the Poker Now csv log is saved before a hand is complete the the last hand in the log will be incomplete and will likely result in causing an error when the ohh file is imported into HM3. It therefore necisarry to check if the final hand is incomplete and if it is, remove the hand from the hands dictionary in order to prevent the script from trying to parse text from an incomplete hand.
A general idea of how to test if the hand information is complete, maybe the line indicating the end of the hand can be useful. The line indicating the end of the hand comes in the form
"-- end of hand #<integer>"
. The integer is the hand number from the line indicating the beginning of the hand. When the last line of the file is parsed we can do a test to check, if the number from the beginning of the hand does not equal the number from the end of the hand then the hand information is incomplete because the last end hand # will be from the previous hand, indicating the file was saved before the final hand was complete.Expected Behavior
All hand converted in ohh should have complete hand information, and any hands with incomplete information should be removed from the hands dictionary before the ohh file is created.
Screenshots
Desktop
Additional Context
Fixing this bug may solve some of the problems in issue #29
The text was updated successfully, but these errors were encountered: