Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last hand may sometimes be incomplete #30

Closed
DrkYoda opened this issue Oct 20, 2022 · 0 comments · Fixed by #34
Closed

The last hand may sometimes be incomplete #30

DrkYoda opened this issue Oct 20, 2022 · 0 comments · Fixed by #34
Assignees
Labels
bug Something isn't working

Comments

@DrkYoda
Copy link
Owner

DrkYoda commented Oct 20, 2022

Description

Is an error generated from this bug?
Yes
Invalid pot size (3) (0.50 vs pot:0.50 rake:0.50 jpt:0.00) for hand #162227643729
If the Poker Now csv log is saved before a hand is complete the the last hand in the log will be incomplete and will likely result in causing an error when the ohh file is imported into HM3. It therefore necisarry to check if the final hand is incomplete and if it is, remove the hand from the hands dictionary in order to prevent the script from trying to parse text from an incomplete hand.
A general idea of how to test if the hand information is complete, maybe the line indicating the end of the hand can be useful. The line indicating the end of the hand comes in the form "-- end of hand #<integer>". The integer is the hand number from the line indicating the beginning of the hand. When the last line of the file is parsed we can do a test to check, if the number from the beginning of the hand does not equal the number from the end of the hand then the hand information is incomplete because the last end hand # will be from the previous hand, indicating the file was saved before the final hand was complete.

Expected Behavior

All hand converted in ohh should have complete hand information, and any hands with incomplete information should be removed from the hands dictionary before the ohh file is created.

Screenshots

image

Desktop

  • OS: Windows 10
  • Version: 10.0.19043
  • Language: Python, OHH, Poker Now
    • Version: 3.2.10, 1.2.2, 3.1.25
  • File: main.py
    • Version: 1.1.2

Additional Context

Fixing this bug may solve some of the problems in issue #29

@DrkYoda DrkYoda added the bug Something isn't working label Oct 20, 2022
@DrkYoda DrkYoda self-assigned this Oct 20, 2022
DrkYoda added a commit that referenced this issue Oct 24, 2022
DrkYoda added a commit that referenced this issue Oct 24, 2022
Fixed issue #30 If the information in the last hand is incomplete then it will not be parsed
@DrkYoda DrkYoda closed this as completed Oct 24, 2022
@DrkYoda DrkYoda linked a pull request Nov 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant