Fixed memory leak when authentication is wrong #178
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an mqtt client that was continously attempting to login with a wrong token into our broker and the memory usage was going up and up.
After digging into the problem, we found that after the connection was closed, two goroutines were still running:
writeLoop()
andserve()
.serve()
was blocked waiting for the closing of theclient.wg.Wait()
, and this wait group was still waiting for thewriteLoop()
to end. And thewriteLoop()
was blocked because it was waiting for theclient.close
channel. The defer in theserve()
closedclient.closed
, but notclient.close
.On this date, we still don't see the difference between
client.closed
andclient.close
, but closingclient.close
in case there is an error was necessary to end both go routines.In any case, I am open to the discussion.
Thanks