Skip to content

Commit

Permalink
Fix build issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Droid-MAX committed Feb 20, 2021
1 parent b5d5864 commit 2268bce
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/bitbang_microwire.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@
#if 0
unsigned char ORG; /* organization 0 = 8 bit and 1 = 16 bit */
#endif
unsigned char CLK;
unsigned char DO;
unsigned char DI;
unsigned char CSEL;
static unsigned char CLK;
static unsigned char DO;
static unsigned char DI;
static unsigned char CSEL;

int org;
int mw_eepromsize;
static int org;
static int mw_eepromsize;

struct MW_EEPROM {
char *name;
Expand Down

7 comments on commit 2268bce

@McMCCRU
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
This is not a correct fix, will not work!

@Droid-MAX
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@McMCCRU I haven't fully tested it, but it solved the problems that occurred during the compilation process.

@Droid-MAX
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use mingw-w64 to cross-compile to windows from linux

@McMCCRU
Copy link

@McMCCRU McMCCRU commented on 2268bce Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If gcc version >= 10.0 try using a flag -fcommon when compiling

@Droid-MAX
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I try it now.

@Droid-MAX
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@McMCCRU You are right, my gcc/mingw-w64-gcc version is 10, but add '-fcommon' flag in Makefile will affect old compiler?or will not?

@McMCCRU
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's compiler flag present as minimum in gcc v.4.x.x...
I fixed the code, try building it with your new compiler.

McMCCRU/SNANDer@c568d81

Please sign in to comment.