fix session lang is null #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
konifar
reviewed
Feb 6, 2017
|
|
||
| public class StringUtil { | ||
|
|
||
| public static boolean isHalfWidthCharacters(String s) { |
There was a problem hiding this comment.
I think it's too much to check the characters 🤔
If lang is null, it should not be bind lang to the view and it's better to hide it like this.
#115 (comment)
What do you think?
There was a problem hiding this comment.
Thank you for review.
I hustle too much 😆
you are right!
There was a problem hiding this comment.
Anyway, your code is interesting!! 👍
I learned the logic from your code 📝
|
Thanks for contribution! Commented 😃 |
konifar
reviewed
Feb 6, 2017
| if (englishTitle) { | ||
| this.languageResId = decideLanguageResId(Session.LANG_EN_ID); | ||
| } | ||
| this.languageResId = decideLanguageResId(Session.LANG_JA_ID); |
|
Sorry, I'll close this PR 🙇 |
|
yes, i will 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot