/conference-app-2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page finishing function when over scrolled to SessionDetailActivity #359

Merged
merged 2 commits into from Feb 18, 2017

Conversation

Reviewers

@konifar konifar

@jmatsu jmatsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@chibatching @konifar @jmatsu @KeithYokoma
@chibatching
Contributor

chibatching commented Feb 17, 2017

Issue

Overview (Required)

  • Finish SessionDetailActivity when page overscrolled

Links

  • none

Screenshot

Before After

@KeithYokoma KeithYokoma added the in progress label Feb 17, 2017

@konifar

This comment has been minimized.

Sign in to view
Collaborator

konifar commented Feb 17, 2017

Cool 🆒
@konifar

This comment has been minimized.

Sign in to view
Collaborator

konifar commented Feb 17, 2017

Interesting implementation 👀
I thought it's better to make custom activity, but your custom CoordinatorLayout also looks good and reasonable. Let me taste this on my device after CI success 👍
@konifar

konifar reviewed Feb 18, 2017
View changes

app/src/main/java/io/github/droidkaigi/confsched2017/view/customview/OverScrollLayout.java


@BindingMethods({
@BindingMethod(type = OverScrollLayout.class, attribute = "onOverScroll", method = "setOverScrollListener")

This comment has been minimized.

Sign in to view
Copy link
@konifar

konifar Feb 18, 2017

Collaborator

🆒
@konifar

This comment has been minimized.

Sign in to view
Collaborator

konifar commented Feb 18, 2017

Sorry to be late review 🙇
I checked on my device. It's really awesome! Thank you so much 👍
LGTM! 💯

@konifar konifar merged commit e470424 into DroidKaigi:master Feb 18, 2017
1 check passed

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@konifar konifar removed the in progress label Feb 18, 2017

@chibatching

This comment has been minimized.

Sign in to view
Contributor

chibatching commented Feb 19, 2017

Thank you for your review!! 😄
@jmatsu

jmatsu reviewed Feb 20, 2017
View changes

app/src/main/java/io/github/droidkaigi/confsched2017/view/customview/OverScrollLayout.java
@Override
public void onStopNestedScroll(View target) {
super.onStopNestedScroll(target);
if (Math.abs(getY()) > overScrollThreshold && overScrollListener != null) {

This comment has been minimized.

Sign in to view
Copy link
@jmatsu

jmatsu Feb 20, 2017

Member

overScrollListener != null should be checked first.
Could you please swap?

This comment has been minimized.

Sign in to view
Copy link
@chibatching

chibatching Feb 20, 2017

Contributor

Oh, I see. I'd like to make another PR to fix it.
@jmatsu

jmatsu reviewed Feb 20, 2017
View changes

app/src/main/java/io/github/droidkaigi/confsched2017/view/customview/OverScrollLayout.java

private int overScrollThreshold;

private PointF originalLocation = new PointF();

This comment has been minimized.

Sign in to view
Copy link
@jmatsu

jmatsu Feb 20, 2017

Member

Rect is better, I think. Then, Rect#getHeight can be used instead of originalHeight.
@jmatsu

jmatsu reviewed Feb 20, 2017
View changes

app/src/main/java/io/github/droidkaigi/confsched2017/view/customview/OverScrollLayout.java
})
public class OverScrollLayout extends CoordinatorLayout {

private static final float OVER_SCROLL_THRESHOLD = 0.20f;

This comment has been minimized.

Sign in to view
Copy link
@jmatsu

jmatsu Feb 20, 2017

Member

This variable is a scale or ratio to calculate threshold?
Can you add any suitable suffix?
@jmatsu

jmatsu reviewed Feb 20, 2017
View changes

app/src/main/java/io/github/droidkaigi/confsched2017/viewmodel/SessionDetailViewModel.java
@@ -157,6 +157,10 @@ public void onClickFab(@SuppressWarnings("unused") View view) {
}
}

public void onOverScroll() {
callback.onOverScroll();

This comment has been minimized.

Sign in to view
Copy link
@jmatsu

jmatsu Feb 20, 2017

Member

should check null or not.
@jmatsu

jmatsu reviewed Feb 20, 2017
View changes

app/src/main/java/io/github/droidkaigi/confsched2017/view/customview/OverScrollLayout.java
}

private boolean isAppBarExpanded(@NonNull AppBarLayout appBarLayout) {
return appBarLayout.getHeight() == appBarLayout.getBottom();

This comment has been minimized.

Sign in to view
Copy link
@jmatsu

jmatsu Feb 20, 2017 •
edited

Member

Does this really work?
View#getHeight() is calculated by View#getBottom() - View#getTop().
Can isAppBarExpanded and View#getTop() == zero be used equally?

This comment has been minimized.

Sign in to view
Copy link
@chibatching

chibatching Feb 20, 2017

Contributor

View#getHeight() is calculated by View#getBottom() - View#getTop()

I didn't know this, it may be able to replaced with View#getTop() == zero.
Thanks!
@jmatsu

This comment has been minimized.

Sign in to view
Member

jmatsu commented Feb 20, 2017 •
edited

Oops, I didn't notice this PR was merged 😇
Sorry, please ignore my reviews.
@chibatching

This comment has been minimized.

Sign in to view
Contributor

chibatching commented Feb 20, 2017 •
edited

I'd like to make another PR to fix your comment! 👍
@konifar

This comment has been minimized.

Sign in to view
Collaborator

konifar commented Feb 20, 2017

@jmatsu Thanks for great review 😄
@chibatching Appreciate you. Looking forward to next PR 👍

@chibatching chibatching deleted the chibatching:add_overscroll_dismiss_function branch Feb 20, 2017

@chibatching chibatching referenced this pull request Feb 20, 2017

Merged

Fix some PR comment #372

@ogapants ogapants referenced this pull request Feb 23, 2017

Merged

Make the status bar transparent on SessionDetailActivity #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment