Fix crash in splash when offline #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1锔忊儯 1锔忊儯 |
konifar
reviewed
Feb 19, 2017
| @@ -73,7 +71,8 @@ private void loadSessionsForCache() { | |||
| if (isFinishing()) return; | |||
| startActivity(MainActivity.createIntent(SplashActivity.this)); | |||
| }) | |||
| .subscribe(); | |||
| .subscribe(objectObservable -> Timber.tag(TAG).d("Succeeded in loading sessions."), | |||
There was a problem hiding this comment.
Can you change valuable to observable from objectObservable?
In fact, lambda variable should be more short name like o, t.
There was a problem hiding this comment.
Succeeded to load sessions. is better?
There was a problem hiding this comment.
I'll fix it soon! Thanks 馃檱
There was a problem hiding this comment.
I think that "succeed to" means "寮曘亶缍欍亹"... 馃
There was a problem hiding this comment.
Oh I didn't know that 馃檱 Thanks
|
LGTM! 馃挴 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
none
Overview (Required)
Since the app has no error handling in
loadSessionsForCache(), it crashes when fails to load sessions in splash. 馃挜I added only logs using Timber.
I think that we need to implement session reloading function in the future.
Links
none
Screenshot
none