Created sessions page #66
Merged
+999
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
|
👁 |
|
🙇 |
KeithYokoma
suggested changes
Jan 27, 2017
| Disposable disposable = viewModel.getSessions(languageId, getContext()) | ||
| .subscribe( | ||
| this::renderSessions, | ||
| throwable -> Timber.e(TAG, "Failed to show sessions.", throwable) |
There was a problem hiding this comment.
I think arguments of Timber.e() should be (Throwable, String, Object...).
You can use Timber.tag(String) to set a log tag before calling e().
There was a problem hiding this comment.
I see. I'll fix this! Thanks!
| } | ||
|
|
||
| switch (topic.id) { | ||
| case 1: |
There was a problem hiding this comment.
Replaced to static fields.
|
Reviewed! |
|
@KeithYokoma Addressed! Can you review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#11
Overview (Required)
Structure
To be honest, I wanted to use
RecyclerView + custom LayoutManager.But it's difficult to catch up in a short time.
So I implemented like this.
I'm using twoway-view which has
SpannableGridLayoutManagerwhich providessetColSpan()andsetRowSpan()to RecyclerView.In fact, the dummy item is filled as blank time slot like below.
I'll try to improve this page by using custom LayoutManager on another PR 💪
Links