Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the position of google-services plugin at the bottom #95

Merged
merged 1 commit into from Feb 6, 2017
Merged

Move the position of google-services plugin at the bottom #95

merged 1 commit into from Feb 6, 2017

Conversation

shiroyama
Copy link
Contributor

Issue

Overview (Required)

  • Move the position of apply plugin: 'com.google.gms.google-services' to the bottom of build.gradle
  • this is required for Firebase to work properly

Links

Screenshot

Before After

konifar
konifar reviewed Feb 6, 2017
View reviewed changes
Copy link
Contributor

@konifar konifar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know this! Thanks!

@konifar
Copy link
Contributor

konifar commented Feb 6, 2017

@srym Sorry, can you rebase? 🙇

@shiroyama shiroyama force-pushed the move_google-services-plugin_at_the_bottom branch from 9b3ae26 to e27f54e Compare February 6, 2017 02:13
@shiroyama
Copy link
Contributor Author

@konifar sure I did! ;)

@konifar konifar merged commit 2b6b239 into DroidKaigi:master Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konifar konifar konifar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiroyama @konifar