Show notification when my session starts #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
changed the title
takahirom
force-pushed
the
show-notification-when-mysession-starts
branch
from
ebfdb02
to
1733377
Compare
|
👍 |
konifar
reviewed
Jan 17, 2018
| val pendingIntent = TaskStackBuilder | ||
| .create(context!!) | ||
| .addNextIntent(MainActivity.createIntent(context)) | ||
| .addNextIntent(SessionDetailActivity.createIntent(context, sessionId)) |
konifar
reviewed
Jan 17, 2018
| if (value) register() else unregister() | ||
| } | ||
|
|
||
| private fun register() { |
There was a problem hiding this comment.
🙋
I thought it's better to pass Session.SpeechSession as method parameter here and instantiate this class by dagger injection. Then you can inject SessionAlarm in ViewModel class.
What do you think?
takahirom
commented
Jan 17, 2018
| .create(context!!) | ||
| .addNextIntent(MainActivity.createIntent(context)) | ||
| .addNextIntent(SessionDetailActivity.createIntent(context, sessionId)) | ||
| .getPendingIntent(1, PendingIntent.FLAG_UPDATE_CURRENT) |
There was a problem hiding this comment.
// I think we should change this id each notification
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Screenshot