Feature/support rtl #606
Feature/support rtl #606
Conversation
|
👁 |
|
I missed your reply 😮 |
|
np |
There was a problem hiding this comment.
TextView has a property for text alignment.
To align the text according to layout direction, use viewStart or viewEnd:
viewStart aligns text to start of the view: Left alignment for LTR layout direction and right alignment for RTL layout direction. viewEnd behaves opposite way.
|
Looks good with
|
| text = when (roomName) { null -> "" | ||
| else -> context.getString(R.string.room_format, prefix, roomName) | ||
| roomName ?: return | ||
| val isLayoutDirectionRtl = resources.configuration.layoutDirection == View.LAYOUT_DIRECTION_RTL |
There was a problem hiding this comment.
Could you extract this comparison as an extension method of View?
There was a problem hiding this comment.
done with 5937050
|
💥Nice! 💥 |
|
Also I add e.g.) Map icon and people icon are changed:
|
| setPadding(start, top, end, bottom) | ||
| } | ||
|
|
||
| fun View.isLayoutDirectionRtl() = |
| @@ -53,7 +53,7 @@ open class BottomNavigationBehavior : CoordinatorLayout.Behavior<BottomNavigatio | |||
| internal fun updateSnackBarPaddingBottomByBottomNavigationView(view: BottomNavigationView) { | |||
| snackbar?.apply { | |||
| val translateY = (view.height - view.translationY).toInt() | |||
| setPadding(paddingLeft, paddingTop, paddingRight, translateY) | |||
| setPadding(paddingEnd, paddingTop, paddingStart, translateY) | |||
There was a problem hiding this comment.
👀 I guess here should be setPaddingWithLayoutDirction(paddingStart, paddingTop, paddingEnd, translateY)
| @@ -34,3 +34,13 @@ var View.elevationForPostLollipop: Float | |||
| elevation = value | |||
| } | |||
| } | |||
|
|
|||
| fun View.setPaddingWithLayoutDirction(start: Int, top: Int, end: Int, bottom: Int) = | |||
| android:layout_marginTop="16dp" | ||
| android:fontFamily="sans-serif-light" | ||
| android:text="@string/about_what_is_prefix" | ||
| android:textColor="#de000000" | ||
| android:textSize="23sp" | ||
| android:textStyle="normal" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintLeft_toLeftOf="@id/conference_name" |
| app:highlightText="@{searchQuery}" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintHorizontal_bias="0.0" | ||
| app:layout_constraintStart_toEndOf="@id/speaker_image" |
| @@ -15,8 +15,10 @@ import android.text.style.StyleSpan | |||
| import android.view.ActionMode | |||
| import android.view.Menu | |||
| import android.view.MenuItem | |||
| import android.view.View | |||
There was a problem hiding this comment.
Could you please check this one?
https://github.com/DroidKaigi/conference-app-2018/pull/606/files#r165896490
Issue
Overview (Required)
session detailscreen shot blow) looks ugly because Japanese and English are NOT RTL language. Should I setandroid:textDirection="locale"or marginEnd as well as marginStart?Screenshot
Set RTL On