Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the build failure on tag-push #680

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Fixed the build failure on tag-push #680

merged 1 commit into from
Sep 27, 2018

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Sep 27, 2018 •
edited
Loading

Issue

Overview (Required)

  • When a build was kicked off by tag-push, some materials like google-service.json were not generated. This PR would fix it.

@jmatsu
- Generate materials even on tag-push
1ae6cb9 
- Use utility functions on bash
@jmatsu jmatsu force-pushed the generate_materials_even_on_tag_push branch from b386b53 to 1ae6cb9 Compare September 27, 2018 02:42
@jmatsu jmatsu changed the title [wip] Fixed the build failure on tag-push Fixed the build failure on tag-push Sep 27, 2018
takahirom
takahirom approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🔖

@jmatsu
Copy link
Contributor Author

jmatsu commented Sep 27, 2018

🥇

@jmatsu jmatsu merged commit f5dfc76 into master Sep 27, 2018
@jmatsu jmatsu deleted the generate_materials_even_on_tag_push branch September 27, 2018 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmatsu @takahirom