Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Search Screen without design #172

Closed
cOnigashima opened this issue Sep 5, 2022 · 8 comments
Closed

create Search Screen without design #172

cOnigashima opened this issue Sep 5, 2022 · 8 comments
Assignees

Comments

@cOnigashima
Copy link
Contributor

Idea Description

  • create only search screen without design
  • fill in name , filtered list shows
  • issue devided apply design

Reference images and links
design coming soon

@takahirom takahirom changed the title create Search Screen create Search Screen without design Sep 5, 2022
@takahirom
Copy link
Member

This screen is planned to be like a Gmail search screen. You can make a query text field and show a result list.

@mtkw0127
Copy link
Contributor

mtkw0127 commented Sep 6, 2022

I’d like to try this issue 💪

@sobaya-0141
Copy link
Contributor

Thanks! Assigned 👍

@mtkw0127
Copy link
Contributor

mtkw0127 commented Sep 7, 2022

@takahirom
@sobaya-0141
I couldn't show time schedule screen like below at main branch.
Android Studio shows the error in Logcat.

If I changed description field of SessionResponse.kt nullable, I can see time table.
Dou you see the table? This is only me? 🤔

@sobaya-0141
Copy link
Contributor

I believe this is being addressed by #246.
Could you try to update it?

@mtkw0127
Copy link
Contributor

mtkw0127 commented Sep 7, 2022

@sobaya-0141
I could run latest main branch. Thank you 👍

I'm junior level developer. so I want to question 😭
speakers is common field Session and Special in TimetableItem.kt.
speakers field move to TimetableItem seald class as abstract field??
Search target is only Session except Special, right?

@takahirom
Copy link
Member

takahirom commented Sep 7, 2022

You can create draft Pull Request to align implementation policies before you spend a lot of time. 👍I'm rooting for you.

I think we can implement the seach(): List method in Timetable class.
And we can implement it by abstract fun isMatch(query): Boolean in TimetableItem and implement it in Special and Session.

@mtkw0127
Copy link
Contributor

mtkw0127 commented Sep 8, 2022

@sobaya-0141
@takahirom
Thanks your kindness.
I opened PR 👍 I worry about my design because this issue doesn't have design 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants