Create search screen #278
Create search screen #278
Conversation
# Conflicts: # app-android/src/main/java/io/github/droidkaigi/confsched2022/KaigiApp.kt # feature-sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/SessionsNavGraph.kt
|
👀 |
|
|
|
@takahirom |
|
|
||
| @OptIn(ExperimentalMaterial3Api::class, ExperimentalComposeUiApi::class) | ||
| @Composable | ||
| private fun SearchTextField(searchWord: String, updateSearchWord: (String) -> Unit) { |
There was a problem hiding this comment.
We use on〜 for state hoisting lambda variables. Because it is event. So How about changing onSearchWordChange from updateSearchWord?
There was a problem hiding this comment.
I changed method name.
| } | ||
|
|
||
| @Composable | ||
| fun SearchScreen( |
There was a problem hiding this comment.
Can you add a Preview function? If we have that, it will be easy to improve it 🙏
There was a problem hiding this comment.
I added preview:pray:
| onItemClick: () -> Unit, | ||
| onBookMarkClick: () -> Unit, | ||
| ) { | ||
| var contentHeight = 100.dp |
There was a problem hiding this comment.
I don't think this is needed. But it is ok now. We can do it later 👍
|
@takahirom |
|
@takahirom |
|
I recommend that you run |
|
@takahirom |
| ) { | ||
| Text( | ||
| text = timeTable.title.currentLangTitle, | ||
| onTextLayout = { |
Issue
create Search Screen without design #172
Overview (Required)
Links
Screenshot