[Proposal]Fix timetable scrolling #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot decide if this should be merged or not. 👀 |
NUmeroAndDev
force-pushed
the
fix_timetable_scrolling
branch
from
efde9f2
to
aceeced
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
feature-sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/Timetable.kt
Outdated
Show resolved
Hide resolved
|
Now, are we able to use HorizontalPager? If so, I would like to merge this PR! |
|
The conflict with |
takahirom
reviewed
Sep 4, 2022
| ) { | ||
| private val velocityTracker = VelocityTracker() | ||
| private val _scrollX = Animatable(initialScrollX) | ||
| private val _scrollY = Animatable(initialScrollY) |
There was a problem hiding this comment.
We can learn Animatable 🆒 Thanks!
https://developer.android.com/jetpack/compose/animation#animatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
detectDragGestures.Links
Screenshot
device-2022-09-04-162628.mp4
device-2022-09-04-162530.mp4