Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timetable hours #151

Merged
merged 7 commits into from
Sep 5, 2022
Merged

Timetable hours #151

merged 7 commits into from
Sep 5, 2022

Conversation

imsakuu
Copy link
Member

@imsakuu imsakuu commented Sep 4, 2022

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • impl the timetable hours
  • Now, the first session of each day is not placed at the top of the timetable layout.
  • The hours is built in the Pager because of ScreenScrollState issues.
    • If possible, it is preferable that the Hours be separated from the Pager.

Links

Screenshot

Before After
hours-before.mp4
hours-after.mp4

@imsakuu imsakuu marked this pull request as ready for review September 5, 2022 00:27
@imsakuu imsakuu changed the title [WIP] Timetable hours design Timetable hours Sep 5, 2022
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being here! 🗓️

}
}
if (isTimetable) {
Timetable(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

) { dayIndex ->
val day = days[dayIndex]
val timetable = scheduleState.schedule.dayToTimetable[day].orEmptyContents()
val timetableState = rememberTimetableState()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@takahirom takahirom merged commit 36f9588 into main Sep 5, 2022
@takahirom takahirom deleted the timetable-hours-design branch September 5, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants