NFC loading and storing implementation for Achievement Rally #1043

momomomo111 · 2023-09-01T01:05:57Z

Issue

close Read URL from NFC tag #354
close Apply changes to the Stamps screen #353

Overview (Required)

The NFC has been configured to trigger animations upon reading, and the results are saved locally.
Commands for verifying NFC
- $ adb shell am start -W -a android.nfc.action.NDEF_DISCOVERED -d "https://confsched2023.page.link/e" io.github.droidkaigi.confsched2023.dev
A ResolveDynamicLinksActivity is being added to resolve DynamicLink's DeepLink, and a CompleteAchievementActivity to trigger animations and save them locally.
The Compose part of the CompleteAchievementActivity has been added to a module called Animation.

Movie (Optional)

demo.mp4

github-actions · 2023-09-01T01:23:39Z

Test Results

209 tests 209 ✔️ 8m 50s ⏱️
  11 suites     0 💤
  11 files     0 ❌

Results for commit b0c441a.

♻️ This comment has been updated with latest results.

# Conflicts: # app-android/src/main/java/io/github/droidkaigi/confsched2023/KaigiApp.kt

github-actions · 2023-09-04T05:34:54Z

Snapshot diff report

File name	Image
AchievementsScreenTe st.checkLaunchShot_2 _compare.png

momomomo111 · 2023-09-04T07:17:21Z

feature/stamps/src/main/java/io/github/droidkaigi/confsched2023/stamps/section/StampList.kt

+            if (uiState.isResetButtonEnabled) {
+                item(
+                    key = "reset_button",
+                    span = { GridItemSpan(SingleItemSpanCount) },
+                ) {
+                    Button(
+                        modifier = Modifier.fillMaxWidth(),
+                        onClick = onReset,
+                    ) {
+                        Text(text = "Reset")
+                    }
+                }
+            }


This button is no longer included in the version of the release

momomomo111 · 2023-09-04T07:21:21Z

app-android/src/main/java/io/github/droidkaigi/confsched2023/ResolveDynamicLinksActivity.kt

+                val intent = Intent(this, MainActivity::class.java)
+                startActivity(intent)
+                finish()


If NFC reading fails, the default screen will be activated

jmatsu

Could you please have a look? Questions are welcome.

app-android/src/main/AndroidManifest.xml

app-android/src/main/java/io/github/droidkaigi/confsched2023/ResolveDynamicLinksActivity.kt

app-android/src/main/java/io/github/droidkaigi/confsched2023/CompleteAchievementActivity.kt

app-android/src/main/AndroidManifest.xml

takahirom · 2023-09-05T06:57:53Z

...ithub/droidkaigi/confsched2023/achievements/animation/AchievementAnimationScreenViewModel.kt

+
+    fun onReachAnimationEnd() {
+        viewModelScope.launch {
+            achievementRepository.saveAchievements(animationLottieRawResStateFlow.value.first)


I think this can be dangerous. This is because the app finishes just after viewModelScope.launch(). So this block can be canceled.
I recommend saving this in onReadDeeplinkHash()

Fixed in the following commit🙏

ed1457c

takahirom · 2023-09-05T14:32:51Z

@momomomo111
I've refactored some classes. Please check it out 🙏
https://github.com/DroidKaigi/conference-app-2023/pull/1043/files/acd3b622d78081008692f82a58bdcda1d520367b..88f53071af1f108387c7903b07094c209f349904

takahirom · 2023-09-05T14:33:28Z

...nts/src/main/java/io/github/droidkaigi/confsched2023/achievements/section/AchievementList.kt

                )
            }
+            if (uiState.isResetButtonEnabled) {


Can we merge this implementation?

@momomomo111 I'm wondering if this button will be released.

takahirom · 2023-09-05T14:40:32Z

I don't check if this works and we don't have any tests for this. Please check it by yourself 🙇

github-actions · 2023-09-05T14:41:47Z

Hi @takahirom! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

momomomo111 · 2023-09-05T22:58:44Z

I don't check if this works and we don't have any tests for this. Please check it by yourself 🙇

I confirmed that A through E actually work after testing them.🙏

takahirom

Thanks for your effort!

takahirom · 2023-09-06T11:59:54Z

I'm not sure if @jmatsu is comfortable with this PR. I believe we can address any issues post-merge. Please let @momomomo111 know if there are any concerns.

Functions from NFC are being implemented.

1099829

github-actions bot temporarily deployed to deploygate-distribution September 1, 2023 01:44 Inactive

momomomo111 added 9 commits September 3, 2023 14:41

Animation support from NFC reading

d6659c8

Create and move modules

74146d9

Migration to ViewModel

1faa0a1

Storage in a data store

2157613

Remove animation

dcc09e1

Add reset button

bf40918

Separate reset buttons

3d13d10

Correction by formatter

b755320

Change package name

d8a517f

DroidKaigi deleted a comment from github-actions bot Sep 3, 2023

Merge branch 'main' into add-dynamic-links-nfc

c76135b

# Conflicts: # app-android/src/main/java/io/github/droidkaigi/confsched2023/KaigiApp.kt

github-actions bot temporarily deployed to deploygate-distribution September 3, 2023 20:53 Inactive

Test Modifications

4d5365c

github-actions bot temporarily deployed to deploygate-distribution September 4, 2023 05:45 Inactive

momomomo111 changed the title ~~Functions from NFC are being implemented.~~ NFC loading and storing implementation for Achievement Rally Sep 4, 2023

momomomo111 marked this pull request as ready for review September 4, 2023 07:10

momomomo111 requested a review from a team as a code owner September 4, 2023 07:10

momomomo111 requested review from upon0426, takahirom and jmatsu September 4, 2023 07:10

momomomo111 commented Sep 4, 2023

View reviewed changes

jmatsu requested changes Sep 4, 2023

View reviewed changes

jmatsu reviewed Sep 4, 2023

View reviewed changes

app-android/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

momomomo111 added 2 commits September 5, 2023 01:28

Modification of hash values

81d338a

Minor name change

9a96c22

momomomo111 requested a review from jmatsu September 5, 2023 06:32

takahirom reviewed Sep 5, 2023

View reviewed changes

momomomo111 added 4 commits September 5, 2023 16:30

Correction of save timing

ed1457c

Change the method of retrieving the url path value

3d693b9

Added handling of parsing failures

acd3b62

Correction by Lint

8a3c1d4

github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 08:51 Inactive

momomomo111 requested a review from takahirom September 5, 2023 08:56

takahirom added 5 commits September 5, 2023 22:58

Simplify DefaultAchievementRepository

95e4fde

Refactor achievement domain model

8c4100a

Some refactor and format

8c17f2b

Fix variable name

a191680

Rename file name

88f5307

takahirom reviewed Sep 5, 2023

View reviewed changes

Hide unneeded top level function

d9fd45d

Fix format

1e01452

github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 15:23 Inactive

Merge branch 'main' into add-dynamic-links-nfc

b0c441a

github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 20:39 Inactive

momomomo111 requested a review from takahirom September 5, 2023 22:59

takahirom approved these changes Sep 6, 2023

View reviewed changes

takahirom mentioned this pull request Sep 6, 2023

✨ Apply stamps initial dialog #1090

Merged

takahirom merged commit 8757ee8 into main Sep 6, 2023
8 checks passed

takahirom deleted the add-dynamic-links-nfc branch September 6, 2023 12:00

kwmt mentioned this pull request Sep 16, 2023

Fixed because it was crashing when launched from NFC without a network connection #1248

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NFC loading and storing implementation for Achievement Rally #1043

NFC loading and storing implementation for Achievement Rally #1043

momomomo111 commented Sep 1, 2023 •

edited

github-actions bot commented Sep 1, 2023 •

edited

github-actions bot commented Sep 4, 2023 •

edited

momomomo111 Sep 4, 2023

momomomo111 Sep 4, 2023

jmatsu left a comment

takahirom Sep 5, 2023

momomomo111 Sep 5, 2023

takahirom commented Sep 5, 2023

takahirom Sep 5, 2023

takahirom Sep 6, 2023

takahirom commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

momomomo111 commented Sep 5, 2023 •

edited

takahirom left a comment

takahirom commented Sep 6, 2023

NFC loading and storing implementation for Achievement Rally #1043

NFC loading and storing implementation for Achievement Rally #1043

Conversation

momomomo111 commented Sep 1, 2023 • edited

Issue

Overview (Required)

Movie (Optional)

github-actions bot commented Sep 1, 2023 • edited

Test Results

github-actions bot commented Sep 4, 2023 • edited

momomomo111 Sep 4, 2023

Choose a reason for hiding this comment

momomomo111 Sep 4, 2023

Choose a reason for hiding this comment

jmatsu left a comment

Choose a reason for hiding this comment

takahirom Sep 5, 2023

Choose a reason for hiding this comment

momomomo111 Sep 5, 2023

Choose a reason for hiding this comment

takahirom commented Sep 5, 2023

takahirom Sep 5, 2023

Choose a reason for hiding this comment

takahirom Sep 6, 2023

Choose a reason for hiding this comment

takahirom commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

momomomo111 commented Sep 5, 2023 • edited

takahirom left a comment

Choose a reason for hiding this comment

takahirom commented Sep 6, 2023

momomomo111 commented Sep 1, 2023 •

edited

github-actions bot commented Sep 1, 2023 •

edited

github-actions bot commented Sep 4, 2023 •

edited

momomomo111 commented Sep 5, 2023 •

edited