✨ Animation was applied to the splash screen. #1050

Corvus400 · 2023-09-02T11:56:40Z

Issue

close Make the splash screen more cool #723

Overview (Required)

Basically, it is almost the same as last year's implementation.

Links

Make the DroidKaigi app splash screen cool conference-app-2022#629

Light	Dark
light.mp4	dark.mp4

Basically, it is almost the same as last year's implementation.

github-actions · 2023-09-02T12:23:28Z

Test Results

215 tests 215 ✔️ 7m 57s ⏱️
  11 suites     0 💤
  11 files     0 ❌

Results for commit 77c4324.

♻️ This comment has been updated with latest results.

github-actions · 2023-09-03T15:53:11Z

Hi @Corvus400! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

…lowing specifications Branded image: this must be 200 x 80 dp.

…he size of the viewport.

Corvus400 · 2023-09-07T09:42:45Z

app-android/src/main/res/values-night/splash_theme.xml

+    <style name="Theme.DroidKaigi.SplashTheme" parent="Theme.SplashScreen">
+        <item name="windowSplashScreenAnimatedIcon">@drawable/splash_icon</item>
+        <item name="windowSplashScreenBackground">@android:color/black</item>
+        <item name="windowSplashScreenAnimationDuration">5000</item>


Would 5,000 milliseconds be long?🤔

Corvus400 · 2023-09-07T09:44:35Z

app-android/src/main/res/drawable-night-v31/splash_branding_image.xml

+    android:width="200dp"
+    android:height="80dp"
+    android:viewportWidth="200"
+    android:viewportHeight="80">


The size of the images in Figma did not meet the requirements if they were imported as is, so the size was manually corrected.

https://developer.android.com/develop/ui/views/launch/splash-screen#dimensions

Branded image: this must be 200×80 dp.

Corvus400 · 2023-09-07T09:45:49Z

app-android/src/main/res/drawable-night-v31/splash_icon.xml

+        <vector
+            android:name="vector"
+            android:width="108dp"
+            android:height="108dp"
+            android:viewportWidth="216"
+            android:viewportHeight="216">
+            <group
+                android:name="group"
+                android:translateX="52"
+                android:translateY="52"
+                >


I had to manually modify the material provided to me because it was clipped when used as is.

Corvus400 · 2023-09-07T09:46:27Z

gradle/libs.versions.toml

@@ -14,6 +14,7 @@ composeHiltNavigatiaon = "1.0.0"
 androidxLifecycle = "2.6.1"
 androidxActivity = "1.8.0-alpha07"
 androidxFragment = "1.6.1"
+androidxSplashScreen = "1.0.1"


The version is one version up from the previous year.

momomomo111 · 2023-09-09T12:33:53Z

@Corvus400
I apologize for the delayed response! 🙏
The splash screen implementation is really cool. Thank you!
I can see differences diff outside of the splash screen area. Do you know the reason for this?

Corvus400 · 2023-09-09T12:55:55Z

@momomomo111

I can see differences diff outside of the splash screen area. Do you know the reason for this?

Does this refer to the screenshot diff?
I'm not sure on my end, as I believe I implemented the same thing as last year... 🙇

https://developer.android.com/guide/topics/ui/splash-screen/migrate?hl=ja#migrate_your_splash_screen_implementation

Corvus400 · 2023-09-09T13:32:08Z

@momomomo111
The results in the screenshot had not changed, so I looked at the documentation and removed the extra description.
80b528c

Corvus400 · 2023-09-09T13:32:59Z

app-android/src/main/java/io/github/droidkaigi/confsched2023/MainActivity.kt

 class MainActivity : ComponentActivity() {
    @OptIn(ExperimentalMaterial3WindowSizeClassApi::class)
    override fun onCreate(savedInstanceState: Bundle?) {
-        super.onCreate(savedInstanceState)
        installSplashScreen()
+        super.onCreate(savedInstanceState)


momomomo111

Thanks! LGTM!

takahirom · 2023-09-10T09:43:24Z

I've been wondering why screenshots change. 🤔
Maybe the application theme is used in Robolectric?
If so, we might be able to prevent this by applying the theme for MainActivity. What do you think?

Corvus400 · 2023-09-10T10:31:20Z

app-android/src/main/AndroidManifest.xml

-        android:theme="@style/Theme.KaigiApp"
        tools:targetApi="tiramisu">
        <meta-data
            android:name="google_analytics_adid_collection_enabled"
            android:value="false" />

        <activity
            android:name=".MainActivity"
-            android:exported="true">
+            android:exported="true"
+            android:theme="@style/Theme.DroidKaigi.SplashTheme">
            <intent-filter>


Corvus400 · 2023-09-10T10:32:25Z

@takahirom
I have added the suggested modifications! 🫡

app-android/src/main/AndroidManifest.xml

Corvus400 · 2023-09-10T14:02:51Z

@takahirom
The screenshot difference no longer occurs successfully.🥳

takahirom

Thanks for implementing this difficult feature!

✨ Animation was applied to the splash screen.

401d1e8

Basically, it is almost the same as last year's implementation.

github-actions bot temporarily deployed to deploygate-distribution September 2, 2023 12:36 Inactive

🔧 EdgeToEdge was disabled and has been fixed.

bc7f14f

github-actions bot temporarily deployed to deploygate-distribution September 2, 2023 15:48 Inactive

Merge branch 'main' into feature/implement_splash_screen_animation

4a6b0a0

🔧 ./gradlew detekt --auto-correct

f5473b7

github-actions bot temporarily deployed to deploygate-distribution September 3, 2023 16:40 Inactive

Corvus400 added 4 commits September 6, 2023 22:26

Merge branch 'main' into feature/implement_splash_screen_animation

bdb6d05

✨ Added a file I forgot to commit.

53bd400

📝 Apply the new icon material.

93b2ed7

📝 Change Duration to 5000 ms.

3c8920b

github-actions bot temporarily deployed to deploygate-distribution September 6, 2023 14:15 Inactive

🔧 Manually corrected the size of the brand image according to the fol…

fde0310

…lowing specifications Branded image: this must be 200 x 80 dp.

github-actions bot temporarily deployed to deploygate-distribution September 6, 2023 15:04 Inactive

🔧 Manually modified the icons so that they are centered relative to t…

255f952

…he size of the viewport.

Corvus400 changed the title ~~[WIP] ✨ Animation was applied to the splash screen.~~ ✨ Animation was applied to the splash screen. Sep 7, 2023

Corvus400 marked this pull request as ready for review September 7, 2023 09:41

Corvus400 requested a review from a team as a code owner September 7, 2023 09:41

Corvus400 requested a review from momomomo111 September 7, 2023 09:41

Corvus400 commented Sep 7, 2023

View reviewed changes

github-actions bot temporarily deployed to deploygate-distribution September 7, 2023 10:18 Inactive

Corvus400 added 2 commits September 8, 2023 00:45

🔧 Adjusted to 60% of the view port size.

f5f91b3

Merge branch 'main' into feature/implement_splash_screen_animation

bd29c91

github-actions bot temporarily deployed to deploygate-distribution September 7, 2023 16:30 Inactive

Merge branch 'main' into feature/implement_splash_screen_animation

7408d34

DroidKaigi deleted a comment from github-actions bot Sep 9, 2023

Corvus400 added 2 commits September 9, 2023 22:30

🔧 Remove extraneous descriptions.

80b528c

https://developer.android.com/guide/topics/ui/splash-screen/migrate?hl=ja#migrate_your_splash_screen_implementation

Merge branch 'main' into feature/implement_splash_screen_animation

b83271f

Corvus400 commented Sep 9, 2023

View reviewed changes

github-actions bot temporarily deployed to deploygate-distribution September 9, 2023 14:12 Inactive

Merge branch 'main' into feature/implement_splash_screen_animation

fbadca1

github-actions bot temporarily deployed to deploygate-distribution September 9, 2023 16:02 Inactive

Merge branch 'main' into feature/implement_splash_screen_animation

7c0fa03

github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 03:46 Inactive

momomomo111 approved these changes Sep 10, 2023

View reviewed changes

🔧 Modified to apply SplashTheme to Activity instead of Application.

1216206

Corvus400 commented Sep 10, 2023

View reviewed changes

github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 11:08 Inactive

DroidKaigi deleted a comment from github-actions bot Sep 10, 2023

Merge branch 'main' into feature/implement_splash_screen_animation

df73c1b

takahirom reviewed Sep 10, 2023

View reviewed changes

app-android/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

Get back the theme for app

f045902

github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 11:57 Inactive

CI RERUN

77c4324

github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 13:59 Inactive

Corvus400 requested a review from takahirom September 10, 2023 14:03

takahirom approved these changes Sep 10, 2023

View reviewed changes

takahirom merged commit 3855375 into DroidKaigi:main Sep 10, 2023
8 checks passed

takahirom mentioned this pull request Sep 12, 2023

Revert ":sparkles: Animation was applied to the splash screen." #1187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Animation was applied to the splash screen. #1050

✨ Animation was applied to the splash screen. #1050

Corvus400 commented Sep 2, 2023 •

edited

github-actions bot commented Sep 2, 2023 •

edited

github-actions bot commented Sep 3, 2023

Corvus400 Sep 7, 2023

Corvus400 Sep 7, 2023

Corvus400 Sep 7, 2023

Corvus400 Sep 7, 2023

momomomo111 commented Sep 9, 2023

Corvus400 commented Sep 9, 2023

Corvus400 commented Sep 9, 2023

Corvus400 Sep 9, 2023

momomomo111 left a comment

takahirom commented Sep 10, 2023

Corvus400 Sep 10, 2023

Corvus400 commented Sep 10, 2023

Corvus400 commented Sep 10, 2023

takahirom left a comment

✨ Animation was applied to the splash screen. #1050

✨ Animation was applied to the splash screen. #1050

Conversation

Corvus400 commented Sep 2, 2023 • edited

Issue

Overview (Required)

Links

github-actions bot commented Sep 2, 2023 • edited

Test Results

github-actions bot commented Sep 3, 2023

Corvus400 Sep 7, 2023

Choose a reason for hiding this comment

Corvus400 Sep 7, 2023

Choose a reason for hiding this comment

Corvus400 Sep 7, 2023

Choose a reason for hiding this comment

Corvus400 Sep 7, 2023

Choose a reason for hiding this comment

momomomo111 commented Sep 9, 2023

Corvus400 commented Sep 9, 2023

Corvus400 commented Sep 9, 2023

Corvus400 Sep 9, 2023

Choose a reason for hiding this comment

momomomo111 left a comment

Choose a reason for hiding this comment

takahirom commented Sep 10, 2023

Corvus400 Sep 10, 2023

Choose a reason for hiding this comment

Corvus400 commented Sep 10, 2023

Corvus400 commented Sep 10, 2023

takahirom left a comment

Choose a reason for hiding this comment

Corvus400 commented Sep 2, 2023 •

edited

github-actions bot commented Sep 2, 2023 •

edited