Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename stamp and badge to achivement #1063

Merged
merged 11 commits into from
Sep 4, 2023
Merged

Rename stamp and badge to achivement #1063

merged 11 commits into from
Sep 4, 2023

Conversation

r4wxii
Copy link
Contributor

@r4wxii r4wxii commented Sep 3, 2023 •
edited

Issue

Overview (Required)

  • Changed the terms stamp, stamps, badge, badges to achievements and achievements in Android code and filenames
    • Since it is not possible to prepare an environment for building iOS immediately, only the Android code was changed

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@github-actions
Copy link

github-actions bot commented Sep 3, 2023 •
edited

Snapshot diff report

File name Image
KaigiAppTest.checkTi
metableTabs_compare.
png
KaigiAppTest.checkNa
vigateToAchievements
Shot_compare.png
KaigiAppTest.checkNa
vigateToFloorMapShot
_compare.png
KaigiAppTest.checkTi
metableTabs_2_compar
e.png
KaigiAppTest.checkNa
vigateToAboutShot_co
mpare.png
KaigiAppTest.checkTi
metableTabs_3_compar
e.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
KaigiAppTest.checkMe
diumTabletLaunchShot
_compare.png
KaigiAppTest.checkMe
diumTabletNavigateTo
FloorMapShot_compare
.png
AchievementsScreenTe
st.checkLaunchShot_2
_compare.png
AchievementsScreenTe
st.checkLaunchShot_c
ompare.png

@github-actions
Copy link

github-actions bot commented Sep 3, 2023 •
edited

Test Results

209 tests   209 ✔️  6m 54s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit c6ebf4a.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 3, 2023 08:10 Inactive
@r4wxii r4wxii force-pushed the rename-stamp-and-badge-to-achivement branch from bbfcfde to 04fb283 Compare September 3, 2023 08:50
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Hi @r4wxii! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@r4wxii r4wxii force-pushed the rename-stamp-and-badge-to-achivement branch from 04fb283 to e730eab Compare September 3, 2023 10:28
@tkhs0604 tkhs0604 mentioned this pull request Sep 3, 2023
Merged
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 3, 2023 16:08 Inactive
@r4wxii r4wxii force-pushed the rename-stamp-and-badge-to-achivement branch from e730eab to 9d196eb Compare September 4, 2023 04:38
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 4, 2023 07:39 Inactive
@r4wxii r4wxii force-pushed the rename-stamp-and-badge-to-achivement branch from 9d196eb to c6ebf4a Compare September 4, 2023 13:28
@takahirom takahirom mentioned this pull request Sep 4, 2023
Closed
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 4, 2023 14:44 Inactive
@takahirom takahirom marked this pull request as ready for review September 4, 2023 23:34
@takahirom takahirom requested review from a team as code owners September 4, 2023 23:34
takahirom
takahirom approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for ensuring the consistency of our app!

@takahirom takahirom merged commit e92ed90 into DroidKaigi:main Sep 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@tomoya0x00 tomoya0x00 Awaiting requested review from tomoya0x00 tomoya0x00 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename stamps and badges to achievements
2 participants
@r4wxii @takahirom