Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed animation issue of TimetableItemDetailScreenTopAppBar #1081

Conversation

tepi0820
Copy link
Contributor

@tepi0820 tepi0820 commented Sep 4, 2023

Issue

Overview (Required)

  • The animation of the timetable detail's top app bar is a little weird, so this fix will make the animation smoother.
  • I have tested out first six sessions' titles to check the behavior. Since max lines of the headline is two, I thought it would be enough if I check cases where the headlines are one or two, but if I should have checked another cases please let me know.

Movie (Optional)

Before After
Screen_recording_20230904_160514.mp4
Screen_recording_20230904_155858.mp4

@tepi0820 tepi0820 requested a review from a team as a code owner September 4, 2023 07:10
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hi @tepi0820! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Snapshot diff report

File name Image
TimetableItemDetailS
creenTest.checkLaunc
hAccessibilityShot_c
ompare.png

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Test Results

209 tests   209 ✔️  6m 54s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 4a42939.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 12:01 Inactive
@tepi0820
Copy link
Contributor Author

tepi0820 commented Sep 6, 2023

Sorry, I ran ./gradlew detekt --auto-correct and fixed the issue detected by GitHub Action.
f91ee7f

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 6, 2023 05:12 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the smooth animation!

@takahirom takahirom merged commit bd1b262 into DroidKaigi:main Sep 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve collapsing animation on timetable item detail screen
2 participants