Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Added display control of the translation function. #1082

Conversation

Corvus400
Copy link
Contributor

Issue

  • None.

Overview (Required)

  • Added a new setting that does not display the Description except for normal sessions since it does not contain a Description.

Movie (Optional)

Before After
before.mp4

Added a new setting that does not display the Description except for normal sessions since it does not contain a Description.
@Corvus400 Corvus400 requested a review from a team as a code owner September 4, 2023 11:35
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Test Results

211 tests   211 ✔️  7m 25s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit a7e08cd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Snapshot diff report

File name Image
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_SearchFilterPrevi
ew-DarkMode-26_27_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_CollapsedTimeta
bleTabRowPreview-Dar
kMode-24_25_null_com
pare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTabPre
view-DarkMode-22_23_
null_compare.png
KaigiAppTest.checkNa
vigateToTimetableIte
mDetailShot_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableShimme
rListItemPreview-Lig
htMode-21_21_null_co
mpare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_TimetablePreview-
LightMode-27_27_null
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailSummaryCardRowPr
eview-DarkMode-19_20
_null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_SearchFilterPrevi
ew-LightMode-26_26_n
ull_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTopAre
aPreview-LightMode-2
5_25_null_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableShimme
rListItemPreview-Dar
kMode-21_22_null_com
pare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailSummaryPreview-D
arkMode-18_19_null_c
ompare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_TimetablePreview-
DarkMode-27_28_null_
compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableListIt
emPreview-LightMode-
20_20_null_compare.p
ng
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_CollapsedTimeta
bleTabRowPreview-Lig
htMode-24_24_null_co
mpare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTabRow
Preview-DarkMode-23_
24_null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableListIt
emPreview-DarkMode-2
0_21_null_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailSummaryCardRowPr
eview-LightMode-19_1
9_null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTopAre
aPreview-DarkMode-25
_26_null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailSummaryPreview-L
ightMode-18_18_null_
compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTabRow
Preview-LightMode-23
_23_null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailScreenTopAppBarU
nSelectableLangPrevi
ew-DarkMode-17_18_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailScreenTopAppBarU
nSelectableLangPrevi
ew-LightMode-17_17_n
ull_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTabPre
view-LightMode-22_22
_null_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 4, 2023 11:55 Inactive
@@ -41,6 +41,7 @@ import kotlinx.collections.immutable.persistentListOf
@Composable
fun TimetableItemDetailScreenTopAppBar(
title: MultiLangText,
isSelectableLang: Boolean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just my preference. But, how about using isLangSelectable? isSelectableLang sounds like this Composable function is a Language for me.

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small point but your insight is amazing!

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 15:48 Inactive
@takahirom takahirom merged commit 183bb34 into DroidKaigi:main Sep 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants