Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] fix calculation to offset item in grid timetable #1084

Merged
merged 4 commits into from
Sep 5, 2023
Merged

[Android] fix calculation to offset item in grid timetable #1084

merged 4 commits into from
Sep 5, 2023
+15 −4

Conversation

tkhs0604
Copy link
Contributor

@tkhs0604 tkhs0604 commented Sep 4, 2023 •
edited

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Each item in grid layout starts from wrong position, so fixed it.
  • The broken layout in day2 is the existing behavior, so keeping it as it is.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Day1 Day2

@tkhs0604 tkhs0604 self-assigned this Sep 4, 2023
@tkhs0604 tkhs0604 requested a review from a team as a code owner September 4, 2023 13:13
tkhs0604
tkhs0604 commented Sep 4, 2023
View reviewed changes
.../sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/section/TimetableGrid.kt Outdated
val dayStart = dayToStartTime[timetableItem.day] ?: dayStartTime
val gridStartTime = LocalTime(hour = 10, minute = 0)
val gridStart =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Help wanted ⚠️]
I am not familiar with how to use date time APIs so much.
I think it is quite dirty and there should be better ways, so I would like some advice to improve this calculation 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: Initial time is 10:00 https://github.com/DroidKaigi/conference-app-2023/blob/main/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/component/TimetableGridHours.kt#L271

@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited

Test Results

209 tests   209 ✔️  8m 0s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit ec5d3de.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited

Snapshot diff report

File name Image
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_Lan
guage_TimetablePrevi
ew-English-16_19_nul
l_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_Lan
guage_TimetablePrevi
ew-Japanese-16_18_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_TimetablePreview-
LightMode-26_26_null
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_TimetablePreview-
DarkMode-26_27_null_
compare.png
TimetableScreenTest.
checkScrollShot_comp
are.png
TimetableScreenTest.
checkGridShot_compar
e.png
TimetableScreenTest.
checkGridScrollShot_
compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 4, 2023 13:34 Inactive
@tkhs0604 tkhs0604 changed the title [Android] fix calculation to offset item in grid view [Android] fix calculation to offset item in grid timetable Sep 4, 2023
@takahirom
Copy link
Member

@tkhs0604 I wanted not to use a fixed time for the start time. So I've changed a little. Could you take a look at it?

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hi @takahirom! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 02:05 Inactive
@tkhs0604
Copy link
Contributor Author

tkhs0604 commented Sep 5, 2023

@takahirom
I checked your commit and LGTM, thank you for improving 🙌

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 03:11 Inactive
takahirom
takahirom approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't noticed this crucial detail. Thank you!

@takahirom takahirom merged commit afc2462 into main Sep 5, 2023
8 checks passed
@takahirom takahirom deleted the kenken/fix_grid_layout branch September 5, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@momomomo111 momomomo111 Awaiting requested review from momomomo111 momomomo111 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees

@tkhs0604 tkhs0604

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tkhs0604 @takahirom