enable back at contributors #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
took the same solution with StaffScreen
takahirom
reviewed
Sep 6, 2023
| @@ -78,6 +79,7 @@ private fun ContributorsScreen( | |||
| null | |||
| } | |||
| val localLayoutDirection = LocalLayoutDirection.current | |||
| val lifecycleOwner = LocalLifecycleOwner.current | |||
There was a problem hiding this comment.
Good catch! Thanks for finding this issue!
But we can't use this function in commonMain because this function is used by iOS 🙏
There was a problem hiding this comment.
Oh, My! Ok, I'll fix it
|
Looks great! Thanks |
takahirom
approved these changes
Sep 9, 2023
|
@takahirom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
Screen_recording_20230904_232601.webm
Screen_recording_20230904_232419.webm