Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added icon resources for dark mode. #1097

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Added icon resources for dark mode. #1097

merged 2 commits into from
Sep 5, 2023

Conversation

saikei718
Copy link
Contributor

@saikei718 saikei718 commented Sep 5, 2023 •
edited

Issue

Overview (Required)

  • Toolbar icons can now be recognized even in dark mode
    • Added icon resources for dark mode.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

FYI(light) Before(dark) After(dark)

@saikei718 saikei718 requested a review from a team as a code owner September 5, 2023 15:43
tkhs0604
tkhs0604 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these icons visible in dark theme 🌃 LGTM!

@tkhs0604 tkhs0604 merged commit 86588f2 into DroidKaigi:main Sep 5, 2023
4 checks passed
@saikei718
Copy link
Contributor Author

A simple issue, but this is my first contribution! thank you!
Next time I'll try a slightly more difficult issue.

@saikei718 saikei718 deleted the fix/timetable-toolbar-items-disappeared-on-darkmode branch September 5, 2023 16:15
@tkhs0604
Copy link
Contributor

tkhs0604 commented Sep 5, 2023

@saikei718
We are really glad to hear that it is your first contribution ✨
Any kind of contribution is quite valuable for us. We are looking for your next contribution every time 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkhs0604 tkhs0604 tkhs0604 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] TimetableView's toolbar items are disappeared on Dark mode
2 participants
@saikei718 @tkhs0604