Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Not to crash on sponsor screen when network is offline #1099

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[Android] Not to crash on sponsor screen when network is offline #1099

merged 1 commit into from
Sep 5, 2023

Conversation

ked4ma
Copy link
Contributor

@ked4ma ked4ma commented Sep 5, 2023

Issue

Overview (Required)

  • By showing snackbar and enable to retry, enable to keep running this app without crash even if offline.

Links

  • nothing

Movie

Before After
Screen_recording_20230906_020811.webm
Screen_recording_20230906_020950.webm

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Test Results

209 tests   209 ✔️  6m 19s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 25a75f7.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2023 17:33 Inactive
@ked4ma ked4ma marked this pull request as ready for review September 5, 2023 18:01
@ked4ma ked4ma requested a review from a team as a code owner September 5, 2023 18:01
RyuNen344
RyuNen344 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@RyuNen344 RyuNen344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G t M

you made app stability robust!! Thank you!!

@RyuNen344 RyuNen344 merged commit 385e032 into DroidKaigi:main Sep 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyuNen344 RyuNen344 RyuNen344 approved these changes

@momomomo111 momomomo111 Awaiting requested review from momomomo111 momomomo111 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] App crashes on sponsor screen when network is offline
2 participants
@ked4ma @RyuNen344