[Android]Enabled scroll functionality during zoom actions. #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @syam4869! Codes seem to be unformatted. To resolve this issue, please run |
|
Snapshot diff report
|
syam4869
changed the title
|
@mhidaka |
|
Let me rerun the job 🙏 |
|
PR work has been completed. |
takahirom
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
I have made adjustments to allow the zoom and scroll functionalities in the timetable grid view to operate simultaneously. Inside the .transformable modifier, I modified the rememberTransformableState callback function. This should allow for the appropriate updating of the vertical scale value using the zoomChange parameter while zoom actions are being conducted.
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
Screen_recording_20230906_203543.mp4