Fix that Time of Day2's keynote is hidden a little #1104
Merged
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
reviewed
Sep 6, 2023
| @@ -123,7 +123,7 @@ fun TimetableGridItem( | |||
|
|
|||
| Row( | |||
| modifier = Modifier | |||
| .weight(1.5f, fill = false) | |||
| .weight(2f, fill = false) | |||
There was a problem hiding this comment.
Thanks! Do you have any idea why this works 👀
There was a problem hiding this comment.
Previously the Row height was not enough, so I tried increasing this value
There was a problem hiding this comment.
Sorry for bothering you. But Could you add some preview functions to confirm small items? Maybe we can pass modifier.size or something to confirm.
There was a problem hiding this comment.
I have no idea. I think the existing preview functions are enough.
There was a problem hiding this comment.
By the way, the following code works also.
Text(
modifier = Modifier.weight(1f, fill = false), // notice
text = timetableItem.title.currentLangTitle,
style = titleTextStyle,
overflow = TextOverflow.Ellipsis,
)
Row(
modifier = Modifier
.weight(1f, fill = false) // notice
.padding(top = TimetableGridItemSizes.titleToSchedulePadding),
) {
...
}
There was a problem hiding this comment.
Hello, I did a30a61e @takahirom
|
Looks great! Thanks! |
takahirom
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
change the TimetableGridItem
Screenshot (Optional if screenshot test is present or unrelated to UI)