Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the time zone to the time on the left of the grid #1137

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Set the time zone to the time on the left of the grid #1137

merged 3 commits into from
Sep 10, 2023

Conversation

ttanaka330
Copy link
Contributor

@ttanaka330 ttanaka330 commented Sep 9, 2023 •
edited

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Set the time zone to the time on the left of the grid

Screenshot (Optional if screenshot test is present or unrelated to UI)

TimeZone Before After
America
Japan
(no change)

@ttanaka330 ttanaka330 requested a review from a team as a code owner September 9, 2023 13:10
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Hi @ttanaka330! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Sep 9, 2023 •
edited

Test Results

215 tests   215 ✔️  6m 57s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 7864cff.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 9, 2023 13:44 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 9, 2023 16:01 Inactive
momomomo111
momomomo111 approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@momomomo111 momomomo111 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@takahirom
Copy link
Member

Looks great! Thanks.

@takahirom takahirom merged commit a856b7a into DroidKaigi:main Sep 10, 2023
8 checks passed
@ttanaka330
Copy link
Contributor Author

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momomomo111 momomomo111 momomomo111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttanaka330 @takahirom @momomomo111