Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AchievementRepository bean def #1141

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Sep 10, 2023

Issue

Overview (Required)

  • AchievementRepository bean definition is missing. So I added that.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@ry-itto ry-itto requested a review from a team as a code owner September 10, 2023 00:34
@ry-itto ry-itto changed the title add missing AchievementRepository bean def Add missing AchievementRepository bean def Sep 10, 2023
@github-actions
Copy link

Hi @ry-itto! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 00:39 Inactive
@ry-itto ry-itto requested a review from a team as a code owner September 10, 2023 00:43
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 00:48 Inactive
@github-actions
Copy link

github-actions bot commented Sep 10, 2023

Test Results

215 tests   215 ✔️  6m 55s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 3b9aecc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@momomomo111 momomomo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also checked the functionality on the Android side.
LGTM!

CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_ASSET_PATHS = "\"DroidKaigi2023/Preview Content\"";
DEVELOPMENT_TEAM = "";
DEVELOPMENT_TEAM = DFY27HWN2G;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is ok to merge. 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is not good. I'll remove this 🙏🏼

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 15:42 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 11, 2023 02:07 Inactive
@ry-itto ry-itto merged commit 53e7633 into main Sep 11, 2023
9 checks passed
@ry-itto ry-itto deleted the add-achievement-repository-to-bean-def branch September 11, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] AchievementRepository dependency not provided
4 participants