Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Improve iOS TimetableDayHeader performance #1163

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Sep 10, 2023

Issue

Overview (Required)

  • This is caused by circular reference between TimetableViewModel instance and TimetabeListView 's closure ( toggleBookmark ).
  • Currently, SwiftUI rendering is recursively called and it is caused by above.

ref: https://developer.apple.com/forums/thread/126890

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-09-11.at.01.53.12.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-09-11.at.01.50.58.mp4

@ry-itto ry-itto requested a review from a team as a code owner September 10, 2023 16:53
Copy link
Contributor

@RyuNen344 RyuNen344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G T M~

@RyuNen344 RyuNen344 merged commit 093bfe6 into main Sep 10, 2023
4 checks passed
@RyuNen344 RyuNen344 deleted the ios-fix-timetable-header-performance branch September 10, 2023 19:38
@ry-itto ry-itto restored the ios-fix-timetable-header-performance branch September 11, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Improve TimetableDayHeader performance
2 participants