Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] 🔧 Nothing is displayed when side event images cannot be loaded. #1197

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[iOS] 🔧 Nothing is displayed when side event images cannot be loaded. #1197

merged 1 commit into from
Sep 12, 2023
+9 −11

Conversation

Corvus400
Copy link
Contributor

Issue

  • None.

Overview (Required)

  • Figma also does not seem to display anything when an image does not exist, so we changed the appearance of the image when it could not be loaded accordingly.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

@Corvus400 Corvus400 requested a review from a team as a code owner September 12, 2023 15:14
ry-itto
ry-itto approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ry-itto ry-itto merged commit 8c7e9c2 into DroidKaigi:main Sep 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Corvus400 @ry-itto