Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Support large size screen #1270

Merged
merged 3 commits into from
Sep 19, 2023
Merged

[iOS] Support large size screen #1270

merged 3 commits into from
Sep 19, 2023

Conversation

coe
Copy link
Contributor

@coe coe commented Sep 18, 2023

Issue

Overview (Required)

  • Change Tab to Sidebar navigation style. only iPad(full screen)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

@coe coe requested a review from a team as a code owner September 18, 2023 17:44
tkhs0604
tkhs0604 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution!
There are some differences between Figma design and this implementation, but looks good as our starting point to adapt large screen 👍

@tkhs0604 tkhs0604 merged commit 33a1266 into DroidKaigi:main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkhs0604 tkhs0604 tkhs0604 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Support large size screen
2 participants
@coe @tkhs0604