Workaround: Inject annotation values to screenshot testing environment at runtime through predefined constants #649
+168
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showkase should pick up and propagete these values even if custom previews are repeated reflective annotations. This workaround just estimates preview configurations from a group and a component key. I guess this is fragile a little bit.
takahirom
reviewed
Aug 17, 2023
| @ShowkaseMultiplePreviewsWorkaround | ||
| @Composable | ||
| private fun ProvidesPreviewValues(group: String, componentKey: String, content: @Composable () -> Unit) { | ||
| val components = componentKey.split("-") |
There was a problem hiding this comment.
This was ambiguous, so fixed in 89bdf36.
takahirom
reviewed
Aug 17, 2023
| @VisibleForTesting | ||
| @Retention(SOURCE) | ||
| @Target(CLASS, FUNCTION) | ||
| annotation class ShowkaseMultiplePreviewsWorkaround |
There was a problem hiding this comment.
For removing someday? This seems useful 👀
There was a problem hiding this comment.
Yes! We should remark code hunks for this workaround cuz they are large and are crosscutting concerns.
takahirom
approved these changes
Aug 17, 2023
Previous implementaion led ambiguous
jmatsu
commented
Aug 17, 2023
|
|
||
| object Japanese { | ||
| const val Name = "Japanese" | ||
| const val Locale = "ja_JP" |
There was a problem hiding this comment.
I've changed this to a locale with a country because Android always provides a country code.
|
Thank you for your reviews~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot