chore(kmm): decrease gradle agp version #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependency diff: dependency diff
branch: chore/setup-ios -> chore/setup-kmm, module: app, configuration: releaseRuntimeClasspath
Upgraded Dependencies
org.jetbrains.kotlin:kotlin-stdlib:1.8.20, (changed from 1.8.10)
org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20, (changed from 1.8.10)
org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.20, (changed from 1.8.10)
org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20, (changed from 1.8.10) |
RyuNen344
commented
May 1, 2023
| @@ -14,12 +14,6 @@ java { | |||
| targetCompatibility = JavaVersion.VERSION_11 | |||
| } | |||
|
|
|||
| kotlin { | |||
There was a problem hiding this comment.
jvmToolchain is a feature of gradle 8
RyuNen344
commented
May 1, 2023
| @@ -26,6 +26,7 @@ hiltGradlePlugin = { group = "com.google.dagger", name = "hilt-android-gradle-pl | |||
|
|
|||
| androidDesugarJdkLibs = { group = "com.android.tools", name = "desugar_jdk_libs", version.ref = "androidDesugarJdkLibs" } | |||
|
|
|||
| composeCompiler = { module = "androidx.compose.compiler:compiler", version.ref = "composeCompiler" } | |||
There was a problem hiding this comment.
define module to be checked by Renovate
RyuNen344
commented
May 1, 2023
| kotlin.mpp.enableCInteropCommonization=true | ||
| kotlin.mpp.stability.nowarn=true | ||
| kotlin.mpp.androidSourceSetLayoutVersion=2 |
There was a problem hiding this comment.
kotlin1.8 brings new source set layout
https://kotlinlang.org/docs/whatsnew18.html#configuration-and-setup
androidTest -> androidUnitTest
androidAndroidTest -> androidInstrumentedTest
RyuNen344
commented
May 1, 2023
There was a problem hiding this comment.
package meta has already moved to build.gradle.
manifest file became empty file, so I deleted.
https://developer.android.com/build/configure-app-module#set-namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#74
AGP 8.0 requests gradle 8, but gradle 8 can't assemble XCFramework
https://youtrack.jetbrains.com/issue/KT-56019
so, decrease gradle to 7.6.1
What
decrease gradle, agp version