Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame Orientation #343

Closed
ghost opened this issue Oct 11, 2013 · 26 comments
Closed

Frame Orientation #343

ghost opened this issue Oct 11, 2013 · 26 comments

Comments

@ghost
Copy link

ghost commented Oct 11, 2013

Hi Arthur,

the frame setup of my hexa is in + mode. Droidplanner shows a quad (which is fine) in + mode but the orientation is wrong. The following image shows the problem.
orientation
On the left side you see the setup of my copter on the right is what I see in Droidplanner. Is there some option to adjust orientation?

Thanks,
Thorsten

@arthurbenemann
Copy link
Member

There is no option to select the orientation of the copter. But if you can generate all the icons for each orientation I can add the code for it. So DroidPlanner will select the correct icon.

@ghost
Copy link
Author

ghost commented Oct 11, 2013

Sure! Can you send me an example (if exists) and or the specifications such as color, size, etc.?

@arthurbenemann
Copy link
Member

The current files are here:
https://github.com/arthurbenemann/droidplanner/tree/master/DroidPlanner/res/drawable-mdpi

They should around 48x48 pixels, and have a x1.5 and x2 version (you want to start with a vector drawing), like it's described here: http://developer.android.com/design/style/iconography.html

@ghost
Copy link
Author

ghost commented Oct 12, 2013

Some first ideas for discussion:
orientation_01
Personally I prefer E.

@ghost
Copy link
Author

ghost commented Oct 12, 2013

Suggestion for hexa:
orientation_02

@arthurbenemann
Copy link
Member

I like both E and F.

@ghost
Copy link
Author

ghost commented Oct 12, 2013

Arthur, below some first examples for testing (with Anti-Alias and white background, and without Anti-Alias)

quad_x_120_w
quad_x_72_w
quad_x_120
quad_x_96
quad_x_48
quad_x_72
quad_x_48_w
quad_x_96_w

@arthurbenemann
Copy link
Member

They need a transparent background, and we only need the ones with anti-alias.

If you are able to compile the code yourself you can give the icons a try by overwriting the default icons on the folder I sent you before. Here is a guide on how to compile the code:
https://github.com/arthurbenemann/droidplanner/wiki/Build-Setup

If you can do a pull request your name will be stored in the program history, if not I can push them myself the next time I have some time to work on the code.

@ghost
Copy link
Author

ghost commented Oct 12, 2013

They should have a transparent background already. It would be great if you can make a test on your system. The question is if the white anti-alias transition looks ok or if some other color such as black or some green or whatever looks better. (Btw, does a transition to transparent work? I'll check tomorrow...) I'll prepare all images then. Do you think we need the hexas?

@arthurbenemann
Copy link
Member

Oh I assumed they had a white background, I'm sorry (reading on phone). The anti-alias should transition to the alpha layer or else the white pixels will show on the map overlay.

I did a build with the mdpi quad icon (48x48), here is how it looks:
https://www.dropbox.com/s/w6fv55qr22t0ben/DP_with_Thorsten_Icons.apk

@ghost
Copy link
Author

ghost commented Oct 12, 2013

Thanks! I will have a look tomorrow and prepare the icons with transitions to the alpha layer.

@ghost
Copy link
Author

ghost commented Oct 14, 2013

Hi Arthur,
here are some new files:

48_ _e

72_ _e

96_ _e

120_ _e

512_ _e

48_x_e

72_x_e

96_x_e

120_x_e

512_x_e

Let me know if I should change anything!
Cheers,
Thorsten

@Blueocean
Copy link

I would like to see line for current Heading, similar as there is in MissionPlanner :
current_heading_line
It could have on/off checkbox in settings and perhaps value for line lenght.

What do you think :) ?

Regards
Jani

@ghost
Copy link
Author

ghost commented Oct 18, 2013

This might be helpful in some situations. However, I guess this needs to be generated on the fly - in the code!?

@arthurbenemann
Copy link
Member

@ThorstenDP
For a static line (that rotates with the icon) it can be just added to the icon .pgn .

To make the proprieties of on/off we can have two different icons (we are starting to get a lot of icons), or generate them in the code.

I just don't want to make that code too heavy so the app start to get stuck because of that.

@ghost
Copy link
Author

ghost commented Oct 18, 2013

Sure I can make it. We only have to discuss the length of the line - and the color (would be nice if it fits to the Droidplanner coloring scheme I guess). The only thing is that it has to be centered correctly...

@ghost
Copy link
Author

ghost commented Oct 21, 2013

Concerning the discussion of colors especially for persons with a red/green color deficit I saw on another forum as well as the question whether different symbols are needed for different types of UAVs, I would like to post a suggestion for a unified symbol (no plane and no copter) as well as a new coloring suggestions. It is just an idea so please feel free to criticize it and/or help to develop it further:

orx

@ghost
Copy link
Author

ghost commented Oct 21, 2013

Arthur et al., here are some files for testing: new design with and without line for current heading.

new_48_s
new_72_s
new_96_s
new_120_s

new_48_l
new_72_l
new_96_l
new_120_l

@arthurbenemann
Copy link
Member

@ThorstenDP
I can't promise that the icons will be on the next release of DP, because I'm very committed to finish the new UI (#308). But you can rest assured that they will be on the new UI.

Here is an screenshot:

@ghost
Copy link
Author

ghost commented Oct 23, 2013

Arthur,
the new UI looks awesome! I think we are not in a hurry to change the icons. I guess it is more important to come up with a good solution. What do you think about the idea of a unified icon as above. I lie the blue you are using and it might be a good idea to use the same for the icon?

@arthurbenemann
Copy link
Member

It may be troublesome to have multiple icons for each drone type, but when we are able to see other people drones on the map it will be worth it.

About the unified icon, it's an interesting idea but it doesn't look nowhere near as good as the other icon you designed.

@ghost
Copy link
Author

ghost commented Oct 23, 2013

:-) Yes, right. It was more about the colors. I also have no problem to use a plane icon. The orientation is easy then.

@ghost
Copy link
Author

ghost commented Oct 23, 2013

Anyway, let me know how to proceed and if I should prepare these (https://github.com/arthurbenemann/droidplanner/issues/343#issuecomment-26279696) icons with a line for current heading.

@arthurbenemann
Copy link
Member

I don't need any other icons for now, when I'm finished with what I have to work up until now I'll give you a call. Thanks.

@arthurbenemann
Copy link
Member

We have a new High Contrast icon that is generic, so I'm closing this.

Thanks for the help @ThorstenDP , but I'll have to drop the cool icons in favor of app usability under the sun.

@ghost
Copy link
Author

ghost commented Dec 13, 2013

Arthur, no problem! (as long as the orientation is correct ;-))
I am curious to see the new icon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants