Refactor: Improve ACRA configuration in Mlauncher.kt

This commit refactors the ACRA configuration in the Mlauncher.kt file to enhance readability and maintainability. Specifically, it restructures the code related to dialog and notification handling based on the value of the 'enableNotifications' preference. This change aims to streamline the ACRA setup process and make it more modular.
DroidWorksStudio · Apr 18, 2024 · 52e1abb · 52e1abb
1 parent fb9407d
commit 52e1abb
Showing 1 changed file with 28 additions and 26 deletions.
diff --git a/app/src/main/java/com/github/droidworksstudio/mlauncher/mLauncher.kt b/app/src/main/java/com/github/droidworksstudio/mlauncher/mLauncher.kt
@@ -83,32 +83,34 @@ class Mlauncher : Application() {
             buildConfigClass = BuildConfig::class.java
             reportFormat = StringFormat.KEY_VALUE_LIST
             //each plugin you chose above can be configured in a block like this:
-            dialog {
-                //required
-                text = getString(R.string.acra_dialog_text).format(pkgName)
-                //optional, enables the dialog title
-                title = getString(R.string.acra_crash)
-                //defaults to android.R.string.ok
-                positiveButtonText = getString(R.string.acra_send_report)
-                //defaults to android.R.string.cancel
-                negativeButtonText = getString(R.string.acra_dont_send)
-                //optional, defaults to @android:style/Theme.Dialog
-                resTheme = R.style.MaterialDialogTheme
-            }
-
-            notification {
-                //required
-                title = getString(R.string.acra_dialog_text).format(pkgName)
-                //required
-                text = getString(R.string.acra_crash)
-                //required
-                channelName = getString(R.string.acra_send_report)
-                //defaults to android.R.string.ok
-                sendButtonText = getString(R.string.acra_send_report)
-                //defaults to android.R.string.cancel
-                discardButtonText = getString(R.string.acra_dont_send)
-                //defaults to false
-                sendOnClick = true
+            if (prefs.enableNotifications) {
+                notification {
+                    //required
+                    title = getString(R.string.acra_dialog_text).format(pkgName)
+                    //required
+                    text = getString(R.string.acra_crash)
+                    //required
+                    channelName = getString(R.string.acra_send_report)
+                    //defaults to android.R.string.ok
+                    sendButtonText = getString(R.string.acra_send_report)
+                    //defaults to android.R.string.cancel
+                    discardButtonText = getString(R.string.acra_dont_send)
+                    //defaults to false
+                    sendOnClick = true
+                }
+            } else {
+                dialog {
+                    //required
+                    text = getString(R.string.acra_dialog_text).format(pkgName)
+                    //optional, enables the dialog title
+                    title = getString(R.string.acra_crash)
+                    //defaults to android.R.string.ok
+                    positiveButtonText = getString(R.string.acra_send_report)
+                    //defaults to android.R.string.cancel
+                    negativeButtonText = getString(R.string.acra_dont_send)
+                    //optional, defaults to @android:style/Theme.Dialog
+                    resTheme = R.style.MaterialDialogTheme
+                }
             }
 
             mailSender {