Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementConverter Element node should be nullable #72

Closed
Tsuki opened this issue Mar 19, 2019 · 0 comments · Fixed by #74
Closed

ElementConverter Element node should be nullable #72

Tsuki opened this issue Mar 19, 2019 · 0 comments · Fixed by #74

Comments

@Tsuki
Copy link

Tsuki commented Mar 19, 2019

Describe the bug
When not matched selector, the ElementConverter.convert is assigning (null,Selector)

To Reproduce
Steps to reproduce the behavior:

  1. implement ElementConverter
class ExistConverter : ElementConverter<Boolean> {
  override fun convert(node: Element, selector: Selector): Boolean {
    return true
  }
}
  1. @Selector("div.nav-previous > a", converter = ExistConverter::class)
  2. Throw java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter node

Expected behavior
Element node remove @NotNull

Screenshots
N/A

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant