Use default value on no match regardless of ElementConverter presence #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
When no match occurs, Jspoon should use the default value given by the user instead of passing
null
to thenode
ofElementConverter
.ElementConverter
shouldn't receivenull
as the Javadoc ofSelector#converter
states that the converter should only be used for matched (i.e. non-null) elements:jspoon/jspoon/src/main/java/pl/droidsonroids/jspoon/annotation/Selector.java
Lines 66 to 68 in 2159364