OpenJdk 21

[DropSnorz]

Summary by CodeRabbit

• Chores
  • Updated the JDK version from 17 to 21 in GitHub Actions workflow for improved build process.
• Refactor
  • Improved task handling in the application by refining state comparison logic.

[coderabbitai]

Walkthrough

The recent update involves upgrading the Java Development Kit (JDK) version from 17 to 21 in the project's GitHub Actions workflows, ensuring the build process utilizes the latest JDK features and security updates. Additionally, the project's codebase has been updated to leverage the latest JavaFX APIs, specifically by importing javafx.concurrent.Worker and updating state comparisons to use Worker.State.FAILED, enhancing code clarity and maintainability.

Changes

File(s)	Summary
.github/workflows/dev.yml, .github/workflows/main.yml	Updated the JDK version from 17 to 21 in GitHub Actions workflows for the build process.
.../core/tasks/AbstractTask.java	Imported javafx.concurrent.Worker and updated state comparison to Worker.State.FAILED in the toString method.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between b579883 and e95c7f1.

Files ignored due to path filters (3)

• owlplug-controls/pom.xml is excluded by: !**/*.xml
• owlplug-host/pom.xml is excluded by: !**/*.xml
• pom.xml is excluded by: !**/*.xml

Files selected for processing (3)

• .github/workflows/dev.yml (1 hunks)
• .github/workflows/main.yml (8 hunks)
• owlplug-client/src/main/java/com/owlplug/core/tasks/AbstractTask.java (2 hunks)

Additional comments: 12

.github/workflows/dev.yml (2)

• 14-14: The change in the JDK setup name from "Set up JDK 17" to "Set up JDK 21" correctly reflects the updated JDK version.
• 18-18: The java-version is updated to 21 to match the new JDK version. Ensure that all Java code in the project is compatible with JDK 21 to avoid build or runtime issues.

owlplug-client/src/main/java/com/owlplug/core/tasks/AbstractTask.java (2)

• 23-23: The import of javafx.concurrent.Worker is correctly added to use Worker.State in the toString method. This change enhances code clarity by explicitly specifying the State enum's source.
• 103-103: Updating the comparison from State.FAILED to Worker.State.FAILED in the toString method improves the maintainability and clarity of the code by explicitly referencing the Worker class's State enumeration. This change is consistent with best practices for readability and maintainability.

.github/workflows/main.yml (8)

• 24-28: The JDK version is updated to 21 in the build-host-win job. This change is correctly applied, ensuring the workflow uses the latest JDK version for the Windows build environment.
• 53-57: The JDK version is updated to 21 in the build-host-osx job. This ensures the macOS build environment is using the latest JDK version, aligning with the project's upgrade to JDK 21.
• 84-88: The JDK version is updated to 21 in the build-host-linux job. This change correctly updates the Linux build environment to use the latest JDK version.
• 116-120: The JDK version is updated to 21 in the build-jar job. This ensures that the Java artifacts are built using the latest JDK version, aligning with the project's upgrade to JDK 21.
• 162-166: The JDK version is updated to 21 in the package-win job. This change ensures that the Windows packaging process uses the latest JDK version.
• 188-192: The JDK version is updated to 21 in the package-osx job. This ensures that the macOS packaging process uses the latest JDK version.
• 213-217: The JDK version is updated to 21 in the package-linux-deb job. This change ensures that the Debian package creation process uses the latest JDK version.
• 238-242: The JDK version is updated to 21 in the package-linux-appimage job. This ensures that the AppImage creation process uses the latest JDK version, aligning with the project's upgrade to JDK 21.