Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #16

Merged
merged 6 commits into from
Dec 3, 2019
Merged

Clean up #16

merged 6 commits into from
Dec 3, 2019

Conversation

Dropelikeit
Copy link
Owner

  • A lot of Bugfixes.
  • Improve tests and add feature tests
  • add phpstan
  • add "composer check, analyze and test" command

BC

  • add Interface method declaration to improve implements classes.
  • remove method "isZeroAmount" from converter and exception class "ConverterException"

@Dropelikeit
- remove unnecessary exceptions,
61ba7fd 
- extension of the tests (feature tests were added for the price calculator)
- static code analysis added.
- code type security improved
@Dropelikeit
- fix code style
b2eec21 
- add DiscountCalculator Feature-Test
@Dropelikeit
- add php travis check for php 7.3 and 7.4
e047ae2
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e047ae2 on clean_up into ba75d68 on master.

@Dropelikeit Dropelikeit merged commit 562acc2 into master Dec 3, 2019
@Dropelikeit Dropelikeit deleted the clean_up branch December 3, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dropelikeit @coveralls