Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for NavController #16

Closed
hgh-bibliophile opened this issue Jul 19, 2020 · 2 comments
Closed

Add Support for NavController #16

hgh-bibliophile opened this issue Jul 19, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@hgh-bibliophile
Copy link

hgh-bibliophile commented Jul 19, 2020

Hello, I really like the design of your library, and I was wondering if you could add the ability to easily set it up with a NavController, as the library I was previously using, ibrahimsn98/SmoothBottomBar, has this functionality. I found how they implemented it, and was able to modify their code to work with your library. I have included the file I modified instead of trying to create a fork of your library, as I am not familiar with how your library works internally.
I don't know if this helps, but I belive this is how they used the NavigationComponentHelper in their main class:

    fun setupWithNavController(menu: Menu, navController: NavController){
        NavigationComponentHelper.setupWithNavController(menu,this,navController)
    }

Thank you for considering this!
NavigationComponentHelper.txt

@Droppers
Copy link
Owner

Will add this as soon as possible, even though it's a little late it's still a useful feature.

@Droppers Droppers added the enhancement New feature or request label Oct 23, 2020
@Droppers Droppers added this to the 1.0.9 milestone Oct 23, 2020
@Droppers
Copy link
Owner

This is now available, released version 1.0.9: implementation 'nl.joery.animatedbottombar:library:1.0.9'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants