This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Blob serialization v 5 + reorganizations #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it_converts tests are failing due to index out of bounds.
… pass (a few still failing).
jamesray1
changed the title
jamesray1
changed the title
This was referenced May 14, 2018
Debug LLDB Support and Task Instructions for Visual Studio Code
…/diamond_drops into blob-serialization-v-5
… dependencies if needed and opens ml.svg.
…/diamond_drops into blob-serialization-v-5
…ndant instructions.
…r debugging The following commands all pass when run with the changes: cargo make test-node; cargo run -- --collation mode -b; cargo make all-with-collation; cargo make test-all
feat: Added Collation flag to CLI that activates example collation for debugging
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://ethresear.ch/t/blob-serialisation/1705.
Uses structs for a chunk and a blob, which contain a data and indicator fields for chunks; and just one data field for blobs (for a blob of arbitrary size). Defines functions for instantiation and conversions between blobs, chunks, bytes. Has unit tests. Add constants instead of using literals.
TODO: serialization for when blobs are larger than a collation. Not a high priority for now. #68. This PR contains pseudocde for that. Update: serialization in #73 for blobs into new collations is added.
TODO: may need to rewrite this to not have a skip_evm flag as per https://ethresear.ch/t/blob-serialisation/1705/15.
Reorganizations
uml-default-recommendedtask that works on different OSes and distros (Uml for different OSs and new tasks in makefile #57).