Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGC-000: PHP 7.4 experiments. #922

Merged
merged 3 commits into from Nov 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion .lando.yml
Expand Up @@ -3,11 +3,20 @@ recipe: drupal8
config:
webroot: docroot
xdebug: false
php: '7.4'
services:
appserver:
xdebug: false
build_as_root:
- apt-get update
- apt-get install libxss1
- echo "Run additional build commands here. Run lando rebuild after updating this file."
- curl -sL https://deb.nodesource.com/setup_15.x | bash -
- apt install -y nodejs
- composer self-update
- wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
- apt install -y ./google-chrome-stable_current_amd64.deb
- rm google-chrome-stable_current_amd64.deb
overrides:
# Pass SSH keys.
volumes:
Expand All @@ -17,8 +26,8 @@ services:
source: "${LANDO_SSH_AUTH_SOCK:-/run/host-services/ssh-auth.sock}"
target: /run/host-services/ssh-auth.sock
environment:
DRUSH_OPTIONS_URI: "https://drupalgovcon.lndo.site/"
SSH_AUTH_SOCK: /run/host-services/ssh-auth.sock
image: 'acquia/ads-local:lando-php-7.3-nodejs-10'
cap_add:
- SYS_ADMIN
tooling:
Expand Down
2 changes: 1 addition & 1 deletion .node-version
@@ -1 +1 @@
14.x
15.x
2 changes: 1 addition & 1 deletion acquia-pipelines.yml
Expand Up @@ -2,7 +2,7 @@ version: 1.2.0
services:
- mysql
- php:
version: 7.3
version: 7.4

variables:
global:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -72,7 +72,7 @@
"minimum-stability": "dev",
"prefer-stable": true,
"require": {
"php": ">=7.3",
"php": ">=7.4",
"acquia/blt": "^12.0",
"acquia/blt-behat": "dev-master",
"acquia/blt-phpcs": "dev-master",
Expand Down
4 changes: 2 additions & 2 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion docroot/themes/custom/twentynineteen/.pa11yci.js
Expand Up @@ -4,7 +4,7 @@
*/

const isCI = process.env.CI;
const baseURL = isCI ? 'http://127.0.0.1:8888' : 'http://drupalgovcon.lndo.site:8080';
const baseURL = isCI ? 'http://127.0.0.1:8888' : 'https://drupalgovcon.lndo.site';

// Add urls for a11y testing here.
const urls = [
Expand All @@ -20,6 +20,7 @@ module.exports = {
hideElements: ['svg'],
ignore: ['notice', 'warning'],
chromeLaunchConfig: {
ignoreHTTPSErrors: true,
args: ['--no-sandbox']
}
},
Expand Down
27 changes: 0 additions & 27 deletions docroot/themes/custom/twentynineteen/install-node.sh

This file was deleted.