Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataManagementSetup implementation must be self-contained #26

Open
mpostol opened this issue Aug 14, 2020 · 1 comment
Open

DataManagementSetup implementation must be self-contained #26

mpostol opened this issue Aug 14, 2020 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@mpostol
Copy link
Collaborator

mpostol commented Aug 14, 2020

According to the concept described in the documentation https://commsvr.gitbook.io/ooi/reactive-communication/semanticdata the DataManagementSetup is an entry point to a part expanding DataRepository class. Therefore it must be self-contained and use ONLY types defined in the assembly. Following this rule, all instances must be created inside this class, and there no reason to provide an implementation of selected interfaces as the parameters. According to all examples, this class is parameterless and this patterns should be followed.

@mpostol mpostol added the bug Something isn't working label Aug 14, 2020
@Drutol
Copy link
Owner

Drutol commented Aug 24, 2020

I've removed the dependencies from constructor as per request and used property injection as per request.

That being said constraining users to certain behaviour makes the library less appealing. Every developer may take different approach which may or may not be worse than the one suggested, library should be flexible enough to fit various implementation approaches.

@mpostol mpostol added question Further information is requested and removed bug Something isn't working labels Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants