Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugs] Another list with stuff #53

Closed
Kimod opened this issue Aug 26, 2016 · 17 comments
Closed

[Bugs] Another list with stuff #53

Kimod opened this issue Aug 26, 2016 · 17 comments

Comments

@Kimod
Copy link

Kimod commented Aug 26, 2016 •
edited by Drutol
Loading

I know you are working hard on something complicated, so I prepared a little list for you so you can take a little break :p

  • Calendar: Reload doesn't respect "Start on Summary" when you reload - http://puu.sh/qPzjo.gif
    • ✔️ Fixed + fixed building calendar bug.
  • Scrollbar in Calendar isn't at the edge (this has nothing to do with that previous scrollbar bug)
    • ✔️ Never ending story ね？
  • Top manga always shows amount of volumes even if you have chapters selected - http://puu.sh/qJb0e.png
    • ✔️ As it turns out I wast too quick with copy pasting and forgot that I don't really have volume data from top anime so they are always going to display this value. + details will now switch volumes/chapters purely for consistency as these values are already visible ^^
  • In manga details, "7" - http://puu.sh/qPyKo.png is the amount of Volumes, not Chapters
    • ✔️ Oh, and I thought I spotted someting...
  • No stock photo for Recoms in Manga details - http://puu.sh/qJbyR.png
    • ✔️ I was wondering how long will this one take you to notice ^^. They had malformed html there but things seem to be okay now.
  • If you click on Seasonal Anime, then on Recommendations, then on Settings & More (or on anime in Recomms), and close it with that swipe, "Recommendations" changes to "Summer 2016 - All" - http://puu.sh/qJgfW.gif
    • ✔️ This was interesting one :)
  • Ok, since you figured out that one above this one, I will give you similar - After a fresh start, if you click in profile or history on anime and then in "Related" on manga, it will change Profile - name/History - name to name - Watching - http://puu.sh/qTHUJ.gif
    • ✔️ Fixed
  • When you first click on "Seasonal Anime", it shows "Summer 2016 - All", but if you click on it again later, it will show "Airing - All"
    • ✔️ Fixed
  • You shouldn't show "Index" in Seasonal Anime / Top anime, because you can't sort that list, so it is pointless
    • ✔️ Fixed
  • Typo - "Decsending" should be "Descending" - http://puu.sh/qJia3.png
    • ✔️ Fixed
  • When I enter number and click on Enter (on keyboard), it says "Wrong Input!", could you change this so it will click on that checkmark or is this some kind of element limitation? - http://puu.sh/qJiza.gif
    • ✔️ Fixed
  • "Airing" in that menu should be 'All' - http://puu.sh/qJjaf.png
    • ✔️ Fixed
  • Select season doesn't work? - http://puu.sh/qPz0V.gif
  • Episodes: "0" should be '?' in recoms - http://puu.sh/qJjst.jpg
    • ✔️ Fixed
  • Should I report all Synopsis things or just don't bother with them? - http://puu.sh/qJkCJ.png
    • 💮 Yeah report them and eventually we will get rid of most of these ^^. I did some fixes here already.
  • When you short shows by Score, could you then sort them by Title? ^^ So your 10/10 should go abc>, then your 9/10 should go abc> http://puu.sh/qPr3F.png
    • ✔️ Done
  • One more Recommendations scaling bug - http://puu.sh/qPq97.gif
    • ✔️ Fixed
  • When you click on friends profile, then on your friend's friend profile, then click on history (or anything else in hamburger menu that doesn't delete back button) and then press that back button, it goes to your friends profile, so it skips your friend's friend - http://puu.sh/qPqja.gif
    • ✔️ Fixed
  • Search magnifier in Anime list disappears, if you click on "Account" in settings - http://puu.sh/qPqNs.gif
    • ✔️ Fixed
  • I swear I only pinned it once… :D (pinned posts multiply in forums) - http://puu.sh/qPryG.gif
    • ✔️ It was very cleverly doubling xd
  • If a person doesn't have Voiceacting/Production Roles, scrollbar is awkwardly small, it should be stretched and while we are at it, shouldn't there also be "No Voice acting roles found"? Or something like that? - http://puu.sh/qPs1X.gif
    • ✔️ Fixed
  • Words "Voiceacting" and "Voiceactors" doesn't exist :D - http://puu.sh/qPscY.jpg
    • ✔️ Nah they do... really believe me...
  • No scrollbar in character details - http://puu.sh/qPsAa.jpg
    • ✔️ Fixed
  • If you try to delete entry you don't have in list, it crashes the app - http://puu.sh/qYBE5.gif
    • ✔️ Fixed
  • Some shows have their airing day still after they are done airing - http://puu.sh/quioF.png , you could probably somehow check for "Status" and if it's Airing > show airing day and if it's Finished Airing > don't show it
  • Arrow to top disappears after you click on a show - http://puu.sh/qz2Li.gif
    • ✔️ Fixed
  • If you search for something in anime list, then if you click on "Anime search" it searches for it, but in "Character search" it doesn't search for it - http://puu.sh/qXkxN.gif
  • Couldn't you chop the empty lines in character details? - http://puu.sh/qPx7M.gif
    • ✔️ Fixed
  • There aren't any spaces between spoilers - http://puu.sh/qPxt3.png maybe have it start at a new line or just insert space?
    • ✔️ Fixed
  • When you extended one review and then clicked on different show and went to reviews, it has one review extended - http://puu.sh/qAiJG.gif
  • So in a lot of places if your internet doesn't work, it will crash the app, which is always a bad thing… Or you know, when MAL went https, it was the same thing, so instead of crashing, just create a dialog, that "Something went wrong™"?
    • ✔️ Fixed™
  • If you click on a show in recommendations multiple times, it will create back arrow for each press - http://puu.sh/qSURS.gif
    • ✔️ Fixed
  • You can't select/write text in "List source", it's unusable now :( - http://puu.sh/qSBRW.png
    • 💮 Same thing as with season selection, bugged anniversary update... I'll consider switching target to previous W10 version.
    • ✔️ After some hacking I got this working but I;m still annoyed by this behavior.
  • If someone has comments disabled, it isn't apparent - http://puu.sh/qSUp4.png
    • ✔️ Fixed
  • In profile, if you switch Focus chapters/volumes, then in "Recent manga" grid items will change the total amount of chapters/volumes only after app restart, whereas in manga list it changes immediately - http://puu.sh/qT7vA.gif
    • ✔️ Fixed

And since I didn't mention it anywhere, my main device is android, so when you will make something for it, I would like to be beta tester too ^^ You know… I like to find stuff :3
@Drutol
Copy link
Owner

Drutol commented Aug 27, 2016

Ufufu, after I finish moving stuff around, everything will require testing because 80% of code has been moved to different place/changed. Major version will jump to 5 because of it ^^

Android is developer's hell in comparison to Microsoft's way of doing things. If people knew what's behind the scenes WP would jump to at least 50% market share granted xd

@Drutol
Copy link
Owner

Drutol commented Aug 27, 2016 •
edited
Loading

Btw, what are you using for mal on android? Atarashii ? How does it compare?

@Kimod
Copy link
Author

Kimod commented Aug 27, 2016

I use Pocket MAL, because i really don't like the layout of Atarashii... I know, it is more feature completed than Pocket MAL, but I will rather use something that is easy to use. When I use mobile to do something with MAL, I don't have to have every feature, I want it to be easy to use and look apealing ^^
I think that feature wise your app as it is now can compete with Atarashii, well maybe Atarashii has still a little more features, but I consider Atarashii really clunky, I don't know, I don't like to use it, I think it is extremly user unfriendly.

How was Hyouka? Can you agree with me that Chitanda is trash tear waifu?

@Drutol
Copy link
Owner

Drutol commented Aug 27, 2016

Hyouka itself was quite good, good enough to pick up light novel, but one-episode fillers were quite irritating.

As for Chitanda I wouldn't consider her waifu at all to be honest it's not what this show focuses on anyway.

Drutol added a commit that referenced this issue Aug 29, 2016
@Drutol
Finishing up porting + a few fixes from #53
ede86b9
Drutol added a commit that referenced this issue Aug 30, 2016
@Drutol
Fixes from #53 part two.
c83c964
Drutol added a commit that referenced this issue Sep 1, 2016
@Drutol
A little bit of #53
392681a
Drutol added a commit that referenced this issue Sep 2, 2016
@Drutol
Fixed messages and some grid items stuff + #53
dd3ecf9
Drutol added a commit that referenced this issue Sep 3, 2016
@Drutol
More&more #53 things
8ebe91f
@Drutol Drutol mentioned this issue Sep 6, 2016
Closed
@Kimod
Copy link
Author

Kimod commented Sep 6, 2016 •
edited
Loading

5.0.0.0 / New

Not Fixed

  • Top manga always shows amount of volumes even if you have chapters selected - http://puu.sh/qJb0e.png / http://puu.sh/r223P.png
    • ✔️ As it turns out I wast too quick with copy pasting and forgot that I don't really have volume data from top anime so they are always going to display this value. + details will now switch volumes/chapters purely for consistency as these values are already visible ^^
    • ❎ same as before :(
    • 💮 As I've said, no data...
    • Oh sorry, I always asumed that check mark is Fixed and flower is works as intended, so I thought you somehow figured it out...
  • In manga details, "7" - http://puu.sh/qPyKo.png is the amount of Volumes, not Chapters
  • ✔️ Oh, and I thought I spotted someting…
  • ❎ same as before :(
  • 💮 Wut, works fine for me...
  • 👂 So it seems it is fine in "Manga list", but if I check it through "Top Manga", it is as it is in my picture, the picture was taken when I clicked on it in "Top Manga"... - http://puu.sh/r2bWq.gif
  • ✔️ Fixed
  • After a fresh start, if you click in profile or history on anime and then in "Related" on manga, it will change Profile - name/History - name to name - Watching - http://puu.sh/qTHUJ.gif
    • ❎ same as before, I guess this witchery is beyond your control :/
    • This must some localized witchery then:
      nobug
  • If someone has comments disabled, it isn't apparent - http://puu.sh/qSUp4.png
    • ✔️ Fixed
    • Just so we are clear, did you read my report correctly? ^^ (I didn't mean if the person doesn't have any comments)
    • 💮 I thought it was good enough ;d
    • 🐈 it's daijoubu ^^

I can't test any bugs fixed in "Seasonal Anime", because I can't open it, so don't consider them fixed just yet! ^^ And I didn't tested mobile just yet, will probably get to it later or tomorrow...

@Drutol
Copy link
Owner

Drutol commented Sep 6, 2016

Do you have anniversary update installed?

@Kimod
Copy link
Author

Kimod commented Sep 6, 2016

Yup, 14393.105

@Drutol
Copy link
Owner

Drutol commented Sep 6, 2016

Odd stuff is happening... seasonal is working fine, no crash after navigating back... I'll send you special slow version if increased debug capabilities ;d

@Drutol
Copy link
Owner

Drutol commented Sep 6, 2016 •
edited
Loading

https://1drv.ms/u/s!Am1xQK-HVf_IkqR7WQfys2gbDouhwQ

Crash this as much as you want, I should get all the logs.

@Kimod
Copy link
Author

Kimod commented Sep 6, 2016 •
edited
Loading

-----error 0x80073CF3, google didn't help... :/-----
Well, somehow I instaled it, but crashes on startup?

@Drutol
Copy link
Owner

Drutol commented Sep 6, 2016

Did you uninstall previous version?

@Kimod
Copy link
Author

Kimod commented Sep 6, 2016

Well, I tried to install it, failed, uninstalled previous version,, then I installed some stuff from "Dependencies" folder and then I was able to install it, but it crashes on startup. Is uninstall enough? Should I look for cashed data and delete that? Because I wasn't able to find any, but if I install any version, I'm always logged in

@Drutol
Copy link
Owner

Drutol commented Sep 6, 2016

It should work out of the box, I'll investigate tommorow.

@Drutol
Copy link
Owner

Drutol commented Sep 7, 2016

Ehh I have too much work to do... I'll be back tomorrow hopefully.

@Kimod
Copy link
Author

Kimod commented Sep 8, 2016 •
edited by Drutol
Loading

I don't know what happened, but 5.0.2.0 no longer crashes on startup, so I'm sorry if I made you look into something that wasn't your fault ^^ (or maybe it is because I downloaded your new 5.0.2.0 from 55). Seasonal anime and going back on pinned forum post no longer crashes.

FIXED
✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️
Mobile Only

  • Show title/Character name isn't displayed - http://puu.sh/r4j59.jpg
  • If I switch "Default view modes for status:" "Watching/Reading" to something different and go back to "Anime list" it crashes
  • Clicking back in "Account" closes app
  • Can't select seasons from combobox, that workaround doesn't work on mobile? :/
  • Sideway scrolling in Anime details - http://puu.sh/r4jlr.jpg
  • Typo decsending -> descending - http://puu.sh/r4ocL.jpg
  • Voiceacting -> Voice Acting - http://puu.sh/r4ofa.jpg

✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️
FIXED

Other

  • When I open calendar, it will open on first day, even if I have "start on summary" selected
    • ✔️ Fixed
  • Every person has two spaces between Birthday month and day - http://puu.sh/r4jNb.jpg
    • 👏 👏 wontfix :D
  • In synopsis "naïve". "ï" is a problem - http://puu.sh/r4jW6.jpg (in app "naïve" is written "naiuml;ve")
    • ✔️ Fixed
  • When you click on friends profile, then on your friend's friend profile, then click on history (or anything else in hamburger menu that doesn't delete back button) and then press that back button, it goes to your friends profile, so it skips your friend's friend - http://puu.sh/qPqja.gif
    • ✔️ Fixed
    • ❎ Still present if you click on "Anime Search", "Recommendations", "Calendar", "Manga Search", "Articles", "News" or "Messaging"
    • 🏁 Maybe now?
  • Why :'( - http://puu.sh/r21br.png please, move the scrollbar in calendar 2 pixels to the right >_<
    • ✔️ Did you really count these pixels or did dig for "2" in code? Yes it was off by 2 pixels.

I swear this is the last comment in this thread bringing new bugs ^^

@Drutol
Copy link
Owner

Drutol commented Sep 8, 2016

Hey, it's not as bad as I imagined!

Drutol added a commit that referenced this issue Sep 10, 2016
@Drutol
#53 fixes - v5.0.5.0
7cc9017
@Kimod
Copy link
Author

Kimod commented Sep 10, 2016

As I promised, that was last comment with bugs, creating new issue ^^

@Kimod Kimod closed this as completed Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kimod @Drutol