Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO2 multipliers incorrect when scenario doesn't exist #29

Closed
Zachary-Kramer opened this issue Jul 18, 2017 · 1 comment
Closed

CO2 multipliers incorrect when scenario doesn't exist #29

Zachary-Kramer opened this issue Jul 18, 2017 · 1 comment
Assignees
@Zachary-Kramer
Labels
bug
Milestone
soilwat_co2_effects

Comments

@Zachary-Kramer
Copy link
Contributor

The array is not initialized to 1 until the scenario is found. The fix is simple (move the initialization up a few lines), but I would like to take a cleaner approach and initialize the array and the multipliers themselves at a single point in the code.
@Zachary-Kramer Zachary-Kramer self-assigned this Jul 18, 2017
@Zachary-Kramer Zachary-Kramer added this to the soilwat_co2_effects milestone Jul 18, 2017
@Zachary-Kramer
Copy link
Contributor Author

This is essentially solved, just waiting for issue #34

Zachary-Kramer added a commit that referenced this issue Aug 19, 2017
@Zachary-Kramer
Add a constructor for the SW_CARBON structure, remove legacy defensiv…
0810780 
…e code

Close #29: CO2 multipliers incorrect when scenario doesn't exist
Close #34: Properly initialize the CO2 variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zachary-Kramer Zachary-Kramer

Labels
bug
Projects
None yet
Milestone
soilwat_co2_effects
Development

No branches or pull requests
1 participant
@Zachary-Kramer