Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biomass scaling for bare-soil evaporation in forbs follows trees instead of grasses #47

Open
dschlaep opened this issue Sep 7, 2017 · 0 comments

Comments

@dschlaep
Copy link
Member

dschlaep commented Sep 7, 2017

Function SW_VPD_init:
Currently, the calculations for the biomass scaling factor for bare-soil evaporation are for

  • Forbs: v->forb.total_agb_daily[doy] = v->forb.litter_daily[doy] + v->forb.biolive_daily[doy];
  • Trees: v->tree.total_agb_daily[doy] = v->tree.litter_daily[doy] + v->tree.biolive_daily[doy];
  • Grasses: v->grass.total_agb_daily[doy] = v->grass.litter_daily[doy] + v->grass.biomass_daily[doy];

However, the calculation for forbs should be following grasses and not trees; correctly, it should be: v->forb.total_agb_daily[doy] = v->forb.litter_daily[doy] + v->forb.biomass_daily[doy];

This looks like a copy-paste-error.

@dschlaep dschlaep added the bug label Sep 7, 2017
@dschlaep dschlaep added this to the Appendix improvements milestone Sep 7, 2017
dschlaep referenced this issue Jan 23, 2018
- address #135

- convert vegetation variables defined in SW_VegProd.h
dschlaep added a commit that referenced this issue Jan 23, 2018
- this commit exactly reproduces output as current master (plus new fix
for forbs #47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant