Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod.in default inputs for CO2 coefficients are confusing #58

Closed
dschlaep opened this issue Sep 13, 2017 · 3 comments
Closed

prod.in default inputs for CO2 coefficients are confusing #58

dschlaep opened this issue Sep 13, 2017 · 3 comments

Comments

@dschlaep
Copy link
Member

The default inputs for CO2 coefficients are confusing because there are four numbers (as if each number applies to one of the four plant functional types -- as used for the inputs earlier in the file).

# CO2 Coefficients: Coeff1 * ppm^Coeff2
# Biomass
# Coeff1 Coeff2
  0.127 0.3501 0. 0.
# WUE
# Coeff1 Coeff2
  22.464 -0.531 0. 0.

==> What are the zeros?

@Zachary-Kramer
Copy link
Contributor

If I remember correctly, the issue was that VegProd.c expects 4 values for every line. The CO2 code only reads in 2, but 4 are required (which I forget why they are). I will revisit this code to see if this reasoning still holds or if there's a better way around it.

@dschlaep
Copy link
Member Author

See comment #57: the four values per line are for the four plant functional types.

@Zachary-Kramer
Copy link
Contributor

I'm implementing it like such:

image

Since issue #57 is a functional issue, and this one is a question, I'm going to combine them into just 57

BrendenBe1 added a commit that referenced this issue Jan 9, 2018
… to issue #120 and issue #109 along with progress on STEPWAT issue #58
BrendenBe1 added a commit that referenced this issue Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants