Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputs for 'CO2EFFECTS' #60

Closed
dschlaep opened this issue Sep 13, 2017 · 3 comments
Closed

Outputs for 'CO2EFFECTS' #60

dschlaep opened this issue Sep 13, 2017 · 3 comments

Comments

@dschlaep
Copy link
Member

Daily output for CO2EFFECTS produces only zeros even while yearly output shows non-zero values.

TIMESTEP dy, yr
...
CO2EFFECTS 		avg 		DY 		1 		end 		co2_effects
@dschlaep dschlaep added the bug label Sep 13, 2017
@dschlaep dschlaep added this to the soilwat_co2_effects milestone Sep 13, 2017
@Zachary-Kramer
Copy link
Contributor

Correct. When we (Caitlin, Charlie, and I) initally laid out the requirements for CO2 output, we were only concerned about monthly and yearly. Thus, daily and weekly are not implemented. Now that CO2 has been developed further, it would be a good time to expand the output to daily and weekly.

@Zachary-Kramer Zachary-Kramer self-assigned this Sep 13, 2017
@dschlaep
Copy link
Member Author

If the CO2 values are the same for each day of a month, then output those for the daily output. If they CO2 values vary for each day, then output those daily values for the daily output.

Outputting 0s suggests that these are the daily values used in the simulation. This is incorrect.

@Zachary-Kramer
Copy link
Contributor

Zachary-Kramer commented Sep 28, 2017

SOILWAT2 now (locally) has daily and weekly output for CO2. Issue will be closed when rSOILWAT2 also has it (which is a matter of allocating slots and adding names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants